gtg team mailing list archive

[Steve Scheel <nmu.sscheel@xxxxxxxxx>]

Steve Scheel has proposed merging lp:~nmu-sscheel/gtg/fix-open-link-while-selecting into lp:gtg.

Requested reviews:
  Gtg developers (gtg)

For more details, see:
https://code.launchpad.net/~nmu-sscheel/gtg/fix-open-link-while-selecting/+merge/99434

I added to the conditionals when the link is to clicked to check and make sure that the link isn't currently selected for copying/pasting/etc. This stops it from opening a link if a user releases on the link while selecting the link, but they will need to double click on the link if there is a piece of the link selected in order to open it.
-- 
https://code.launchpad.net/~nmu-sscheel/gtg/fix-open-link-while-selecting/+merge/99434
Your team Gtg developers is requested to review the proposed merge of lp:~nmu-sscheel/gtg/fix-open-link-while-selecting into lp:gtg.

=== modified file 'AUTHORS'
--- AUTHORS	2012-03-26 22:18:17 +0000
+++ AUTHORS	2012-03-26 22:20:29 +0000
@@ -98,4 +98,8 @@
 * huxuan <i@xxxxxxxxxx>
 * Nimit Shah <nimit.svnit@xxxxxxxxx>
 * Abdul Rauf <abdulraufhaseeb@xxxxxxxxx>
+<<<<<<< TREE
 * Radina Matic <radina.matic@xxxxxxxxx>
+=======
+* Steve Scheel <nmu.sscheel@xxxxxxxxx>
+>>>>>>> MERGE-SOURCE

=== modified file 'CHANGELOG'
--- CHANGELOG	2012-03-22 13:50:35 +0000
+++ CHANGELOG	2012-03-26 22:20:29 +0000
@@ -1,3 +1,5 @@
+2012-03-26
+    * Stopped links from opening when accidently letting go of mouse button while selecting them
 2012-0?-?? Getting Things GNOME! 0.3
     * Hide tasks with due date someday, #931376
     * New Date class by Paul Kishimoto and Izidor Matušov

=== modified file 'GTG/gtk/editor/taskview.py'
--- GTG/gtk/editor/taskview.py	2012-03-22 13:32:49 +0000
+++ GTG/gtk/editor/taskview.py	2012-03-26 22:20:29 +0000
@@ -1330,7 +1330,7 @@
                 if typ == "subtask":
                     self.open_task(anchor)
                 elif typ == "http":
-                    if button == 1 and self.check_link(anchor):
+                    if button == 1 and self.check_link(anchor) and self.buff.get_has_selection() == False:
                         openurl(anchor)
                 else:
                     print "Unknown link type for %s" %anchor