gtg team mailing list archive

[Nimit Shah <nimit.svnit@xxxxxxxxx>]

Nimit Shah has proposed merging lp:~nimit-svnit/gtg/bug-1067738 into lp:gtg.

Requested reviews:
  Gtg developers (gtg)
Related bugs:
  Bug #1067738 in Getting Things GNOME!: "quick-add bar search query does not get cleared"
  https://bugs.launchpad.net/gtg/+bug/1067738

For more details, see:
https://code.launchpad.net/~nimit-svnit/gtg/bug-1067738/+merge/130663

Added string emptying code lines at different methods in browser.py
-- 
https://code.launchpad.net/~nimit-svnit/gtg/bug-1067738/+merge/130663
Your team Gtg developers is requested to review the proposed merge of lp:~nimit-svnit/gtg/bug-1067738 into lp:gtg.

=== modified file 'CHANGELOG'
--- CHANGELOG	2012-09-08 08:10:51 +0000
+++ CHANGELOG	2012-10-20 09:25:23 +0000
@@ -53,6 +53,7 @@
     * Fix for bug-1037051 (Due date is not set for a new subtask), by Nimit Shah
     * Fix for bug #1036955: Due date is not preselected when start date is filled, by Steve Scheel
     * Fix for bug #1045036: Slovak Translation Updated by Slavko
+    * Fix for bug #1067738: Quick-add bar string not cleared, by Nimit Shah
 
 2012-02-13 Getting Things GNOME! 0.2.9
     * Big refractorization of code, now using liblarch

=== modified file 'GTG/gtk/browser/browser.py'
--- GTG/gtk/browser/browser.py	2012-08-12 23:01:10 +0000
+++ GTG/gtk/browser/browser.py	2012-10-20 09:25:23 +0000
@@ -825,6 +825,7 @@
         """
         deals with mouse click event on the tag tree
         """
+        self.quickadd_entry.set_text('')
         Log.debug("Received button event #%d at %d, %d" % (
             event.button, event.x, event.y))
         if event.button == 3:
@@ -867,6 +868,7 @@
             return True
 
     def on_tag_treeview_key_press_event(self, treeview, event):
+        self.quickadd_entry.set_text('')
         keyname = gtk.gdk.keyval_name(event.keyval)
         is_shift_f10 = (keyname == "F10" and
             event.get_state() & gtk.gdk.SHIFT_MASK)
@@ -890,6 +892,7 @@
     def on_task_treeview_button_press_event(self, treeview, event):
         """ Pop up context menu on right mouse click in the main
         task tree view """
+        self.quickadd_entry.set_text('')
         Log.debug("Received button event #%d at %d,%d" % (
             event.button, event.x, event.y))
         if event.button == 3:
@@ -922,6 +925,7 @@
             return True
 
     def on_closed_task_treeview_button_press_event(self, treeview, event):
+        self.quickadd_entry.set_text('')
         if event.button == 3:
             x = int(event.x)
             y = int(event.y)
@@ -935,6 +939,7 @@
             return True
 
     def on_closed_task_treeview_key_press_event(self, treeview, event):
+        self.quickadd_entry.set_text('')
         keyname = gtk.gdk.keyval_name(event.keyval)
         is_shift_f10 = (keyname == "F10" and
             event.get_state() & gtk.gdk.SHIFT_MASK)