← Back to team overview

gtg team mailing list archive

[Merge] lp:~kmhpfoss/gtg/bug-fix- into lp:gtg

 

Codee has proposed merging lp:~kmhpfoss/gtg/bug-fix- into lp:gtg.

Requested reviews:
  Gtg developers (gtg)

For more details, see:
https://code.launchpad.net/~kmhpfoss/gtg/bug-fix-/+merge/135490

Fixed the bug related to changing date manually mentioned in https://bugs.launchpad.net/gtg/+bug/1047753
Included event handlers for entry focus lost event and enter key pressed event
-- 
https://code.launchpad.net/~kmhpfoss/gtg/bug-fix-/+merge/135490
Your team Gtg developers is requested to review the proposed merge of lp:~kmhpfoss/gtg/bug-fix- into lp:gtg.
=== modified file 'GTG/gtk/editor/editor.py'
--- GTG/gtk/editor/editor.py	2012-08-26 16:41:47 +0000
+++ GTG/gtk/editor/editor.py	2012-11-21 18:06:22 +0000
@@ -68,6 +68,15 @@
         self.subtask_button.set_tooltip_text(GnomeConfig.SUBTASK_TOOLTIP)
         self.inserttag_button = self.builder.get_object("inserttag")
         self.inserttag_button.set_tooltip_text(GnomeConfig.TAG_TOOLTIP)
+
+        ###################################Newly added bug fixes#############################
+
+        self.duedate_widget = self.builder.get_object("duedate_entry")
+        self.startdate_widget = self.builder.get_object("startdate_entry")
+        self.closeddate_widget = self.builder.get_object("closeddate_entry")
+
+        #############################End this section - go to next###########################
+
         #Create our dictionary and connect it
         dic = {
                 "mark_as_done_clicked": self.change_status,
@@ -89,6 +98,17 @@
                 "on_insert_subtask_clicked": self.insert_subtask,
                 "on_inserttag_clicked": self.inserttag_clicked,
                 "on_move": self.on_move,
+
+                ###focus lost events of entry objects
+                "startdate_entry_focus_out" : (self.date_changed_manually, GTGCalendar.DATE_KIND_START),
+                "duedate_entry_focus_out" : (self.date_changed_manually, GTGCalendar.DATE_KIND_DUE),
+                "closeddate_entry_focus_out" : (self.date_changed_manually, GTGCalendar.DATE_KIND_CLOSED),
+
+                ###enter key pressed events of entry objects
+                "startdate_entry_activate" : (self.date_changed_manually, GTGCalendar.DATE_KIND_START),
+                "duedate_entry_activate" : (self.date_changed_manually, GTGCalendar.DATE_KIND_DUE),
+                "closeddate_entry_activate" : (self.date_changed_manually, GTGCalendar.DATE_KIND_CLOSED),
+
         }
         self.builder.connect_signals(dic)
         self.window         = self.builder.get_object("TaskEditor")
@@ -109,9 +129,6 @@
             self.textview.modify_font(pango.FontDescription(conf_font_value)) 
         #Voila! it's done
         self.calendar       = GTGCalendar(self.builder)
-        self.duedate_widget = self.builder.get_object("duedate_entry")
-        self.startdate_widget = self.builder.get_object("startdate_entry")
-        self.closeddate_widget = self.builder.get_object("closeddate_entry")
         self.dayleft_label  = self.builder.get_object("dayleft")
         self.tasksidebar = self.builder.get_object("tasksidebar")
         # Define accelerator keys
@@ -560,3 +577,10 @@
 
     def get_window(self):
         return self.window
+
+    #This will be called when user manually changed the date in the entries of
+    #starting date, due date and closed date
+    #To refresh the other UI components this will call the required functions within it
+    def date_changed_manually(self, widget, event=None, type=None):
+        self.date_changed(widget, type)
+        self.refresh_editor()

=== modified file 'GTG/gtk/editor/taskeditor.glade'
--- GTG/gtk/editor/taskeditor.glade	2012-05-23 08:55:31 +0000
+++ GTG/gtk/editor/taskeditor.glade	2012-11-21 18:06:22 +0000
@@ -168,6 +168,8 @@
                     <property name="invisible_char">&#x25CF;</property>
                     <property name="width_chars">10</property>
                     <signal name="changed" handler="startingdate_changed"/>
+                    <signal name="focus-out-event" handler="startdate_entry_focus_out"/>
+                    <signal name="activate" handler="startdate_entry_activate"/>
                   </object>
                   <packing>
                     <property name="expand">False</property>
@@ -225,6 +227,8 @@
                     <property name="invisible_char">&#x25CF;</property>
                     <property name="width_chars">10</property>
                     <signal name="changed" handler="duedate_changed"/>
+                    <signal name="focus-out-event" handler="duedate_entry_focus_out"/>
+                    <signal name="activate" handler="duedate_entry_activate"/>
                   </object>
                   <packing>
                     <property name="expand">False</property>
@@ -282,6 +286,8 @@
                     <property name="invisible_char">&#x25CF;</property>
                     <property name="width_chars">10</property>
                     <signal name="changed" handler="closeddate_changed"/>
+                    <signal name="focus-out-event" handler="closeddate_entry_focus_out"/>
+                    <signal name="activate" handler="closeddate_entry_activate"/>
                   </object>
                   <packing>
                     <property name="expand">False</property>