gtg team mailing list archive

[Parin Porecha <parinporecha@xxxxxxxxx>]

Parin Porecha has proposed merging lp:~parinporecha/gtg/more_patches into lp:gtg.

Requested reviews:
  Gtg developers (gtg)
Related bugs:
  Bug #1079143 in Getting Things GNOME!: "Adding the same custom color in tag editor multiple times raises an Exception"
  https://bugs.launchpad.net/gtg/+bug/1079143

For more details, see:
https://code.launchpad.net/~parinporecha/gtg/more_patches/+merge/143050

This is a patch for the Bug #1079143 ( Adding the same custom color in tag editor multiple times raises an Exception ).
-- 
https://code.launchpad.net/~parinporecha/gtg/more_patches/+merge/143050
Your team Gtg developers is requested to review the proposed merge of lp:~parinporecha/gtg/more_patches into lp:gtg.

=== modified file 'CHANGELOG'
--- CHANGELOG	2013-01-11 15:14:38 +0000
+++ CHANGELOG	2013-01-13 20:20:26 +0000
@@ -10,6 +10,7 @@
     * Russian localization of help by DmDr
     * Fix for bug #1096622: Damaged image in the help, by Parin Porecha
     * Fix for bug #1095390: Quick Add bar incorrectly parses tags, by Parin Porecha
+    * Fix for bug #1079143: Adding the same custom color in tag editor multiple times raises an Exception, by Parin Porecha
 
 2012-11-06 Getting Things GNOME! 0.3
     * Hide tasks with due date someday, #931376

=== modified file 'GTG/gtk/browser/simple_color_selector.py'
--- GTG/gtk/browser/simple_color_selector.py	2012-12-09 12:18:39 +0000
+++ GTG/gtk/browser/simple_color_selector.py	2013-01-13 20:20:26 +0000
@@ -216,6 +216,7 @@
         cc_vbox.set_spacing(4)
         cc_hbox = gtk.HBox()
         cc_vbox.pack_start(cc_hbox)
+        self.custom_colors = list(set(self.custom_colors))
         for i in xrange(len(self.custom_colors)):
             # add the color box
             img = SimpleColorSelectorPaletteItem()