← Back to team overview

gtg team mailing list archive

[Merge] lp:~nimit-svnit/gtg/bug-1141582 into lp:gtg

 

Nimit Shah has proposed merging lp:~nimit-svnit/gtg/bug-1141582 into lp:gtg.

Requested reviews:
  Gtg developers (gtg)
Related bugs:
  Bug #1141582 in Getting Things GNOME!: "crash on enabling hamster plugin"
  https://bugs.launchpad.net/gtg/+bug/1141582

For more details, see:
https://code.launchpad.net/~nimit-svnit/gtg/bug-1141582/+merge/151385

Small change in the hamster.py file: replaced self.PLUGIN_NAME with SELF.PLUGIN_NAMESPACE
-- 
https://code.launchpad.net/~nimit-svnit/gtg/bug-1141582/+merge/151385
Your team Gtg developers is requested to review the proposed merge of lp:~nimit-svnit/gtg/bug-1141582 into lp:gtg.
=== modified file 'CHANGELOG'
--- CHANGELOG	2013-02-25 07:35:07 +0000
+++ CHANGELOG	2013-03-03 08:04:22 +0000
@@ -15,6 +15,7 @@
     * Added command "gtcli overview"
     * Fix for bug #1076029: (Fixed regression) Notification area applet can't display attention icon
     * Pep8ification of code, by Nimit Shah
+    * Fix for bug #1141582: Crash on enabling hamster plugin, by Nimit Shah
 
 2012-11-06 Getting Things GNOME! 0.3
     * Hide tasks with due date someday, #931376

=== modified file 'GTG/plugins/hamster/hamster.py'
--- GTG/plugins/hamster/hamster.py	2013-02-25 07:35:07 +0000
+++ GTG/plugins/hamster/hamster.py	2013-03-03 08:04:22 +0000
@@ -308,7 +308,7 @@
 
     def preferences_load(self):
         self.preferences = self.plugin_api.load_configuration_object(
-            self.PLUGIN_NAME, "preferences",
+            self.PLUGIN_NAMESPACE, "preferences",
             default_values=self.DEFAULT_PREFERENCES)
 
     def preferences_store(self):


Follow ups