gtg team mailing list archive

[Sara Ribeiro <sara.rmgr@xxxxxxxxx>]

Sara Ribeiro has proposed merging lp:~sara.ribeiro/gtg/new_label into lp:gtg.

Requested reviews:
  Gtg developers (gtg)
Related bugs:
  Bug #1288011 in Getting Things GNOME!: "More intuitive title label for tasks"
  https://bugs.launchpad.net/gtg/+bug/1288011

For more details, see:
https://code.launchpad.net/~sara.ribeiro/gtg/new_label/+merge/209362

Changed the title labels to on the main and closed tasks panel to "Tasks" and "Closed Tasks", respectively.
-- 
https://code.launchpad.net/~sara.ribeiro/gtg/new_label/+merge/209362
Your team Gtg developers is requested to review the proposed merge of lp:~sara.ribeiro/gtg/new_label into lp:gtg.

=== modified file 'AUTHORS'
--- AUTHORS	2014-02-26 07:00:43 +0000
+++ AUTHORS	2014-03-05 02:15:00 +0000
@@ -132,3 +132,4 @@
 * Sagar Ghuge <ghugesss@xxxxxxxxx>
 * Sushant Raikar <sushantthecoder@xxxxxxxxx>
 * Atit Anand <atit.anand.cs@xxxxxxxxx>
+* Sara Ribeiro <sara.rmgr@xxxxxxxxx>

=== modified file 'CHANGELOG'
--- CHANGELOG	2014-03-03 17:38:49 +0000
+++ CHANGELOG	2014-03-05 02:15:00 +0000
@@ -17,6 +17,7 @@
     * Fix for bug #644993 : Automatic generation of tag color, by Atit Anand
     * Fix for bug #1286491 : RTM sync backend fails to load, by Pawan Hegde
     * Fix for bug #1286493 : GTG cannot connect to RTM, by Pawan Hegde
+    * Fix for bug #1288011 : More intuitive title label for tasks, by Sara Ribeiro
 
 2013-11-24 Getting Things GNOME! 0.3.1
     * Fix for bug #1024473: Have 'Show Main Window' in notification area, by Antonio Roquentin

=== modified file 'GTG/gtk/browser/treeview_factory.py'
--- GTG/gtk/browser/treeview_factory.py	2014-02-26 07:00:43 +0000
+++ GTG/gtk/browser/treeview_factory.py	2014-03-05 02:15:00 +0000
@@ -314,7 +314,7 @@
 
     def active_tasks_treeview(self, tree):
         # Build the title/label/tags columns
-        desc = self.common_desc_for_tasks(tree)
+        desc = self.common_desc_for_tasks(tree, "Tasks")
 
         # "startdate" column
         col_name = 'startdate'
@@ -345,7 +345,7 @@
 
     def closed_tasks_treeview(self, tree):
         # Build the title/label/tags columns
-        desc = self.common_desc_for_tasks(tree)
+        desc = self.common_desc_for_tasks(tree, "Closed Tasks")
 
         # "startdate" column
         col_name = 'closeddate'
@@ -365,7 +365,7 @@
 
     # This build the first tag/title columns, common
     # to both active and closed tasks treeview
-    def common_desc_for_tasks(self, tree):
+    def common_desc_for_tasks(self, tree, title_label):
         desc = {}
 
         # invisible 'task_id' column
@@ -411,7 +411,7 @@
         # "label" column
         col_name = 'label'
         col = {}
-        col['title'] = _("Title")
+        col['title'] = _(title_label)
         render_text = Gtk.CellRendererText()
         render_text.set_property("ellipsize", Pango.EllipsizeMode.END)
         col['renderer'] = ['markup', render_text]