gufw-developers team mailing list archive

[Matthew Paul Thomas <mpt@xxxxxxxxxxxxx>]

That looks much better. Unfortunately I don't have time for a proper
review now, but I have one suggestion. Look at the interface for adding
recipients when composing a message in Thunderbird. Notice how you don't
need to open a separate window to add a recipient. You could use a
similar approach to eliminate the "Add Rule" window altogether: instead
of configuring a new rule in a separate window, configure it inside a
new row in the "Rules" list.

-- 
Various visual glitches
https://bugs.launchpad.net/bugs/451160
You received this bug notification because you are a member of Gufw
Developers, which is the registrant for Gufw.

Status in GUI for ufw: Confirmed

Bug description:
I do not use gufw, but based on the screenshot in <http://img126.imageshack.us/img126/7526/screenshot1i.png>, it has a few visual design glitches.

* All the buttons do not have enough padding: they should have "12 pixels of padding to either side of centered text" <http://library.gnome.org/devel/hig-book/stable/design-text-labels.html.en#layout-label-position>.

* Grouped buttons, e.g. "Add" and "Remove", should be the same width: "If appearing in a group of buttons, longest button label sets button size" <http://library.gnome.org/devel/hig-book/stable/design-text-labels.html.en#layout-label-position>.

* The "Incoming" and "Outgoing" menu labels should end with colons, i.e. "Incoming:" and "Outgoing:". This is not specified in the HIG explicitly, but is shown in all the examples in <http://library.gnome.org/devel/hig-book/stable/controls-option-menus.html.en>.

* The "Rules" listbox should have a border to make it look inset. Compare the screenshots in <http://library.gnome.org/devel/hig-book/stable/controls-trees.html.en>.

* ( Remove ) ( Add ) should be ( Add… ) ( Remove ), like it is in other programs that have that pair of buttons.

* The resize grippy for a window should be in the corner of the window.

* The "Add new rule" dialog should instead be "Add Rule". <http://library.gnome.org/devel/hig-book/stable/design-text-labels.html.en#layout-capitalization>

* In the same dialog, ( Close ) ( Add ) should be ( Cancel ) (( Add )).

It may help to split this bug report into eight bug reports that can be tracked separately.