gufw-developers team mailing list archive

[costales <1410839@xxxxxxxxxxxxxxxxxx>]

Hi! Thanks a lot for your feedback!

The user only can to create profiles with letters, numbers, dashes and 
underscores.
http://bazaar.launchpad.net/~costales/gui-ufw/gufw-15.04/view/head:/gufw/view/preferences.py#L101 
<http://bazaar.launchpad.net/%7Ecostales/gui-ufw/gufw-15.04/view/head:/gufw/view/preferences.py#L101>
A profile with semicolons will be reject.

I was thinking about to filter in the ufw_backend.py in any way?
Best regards!

-- 
You received this bug notification because you are a member of Gufw
Developers, which is subscribed to Gufw.
https://bugs.launchpad.net/bugs/1410839

Title:
  Shell Command injection in ufw_backend.py

Status in Gufw:
  New

Bug description:
  Firewall Administrators can be tricked by someone to export a profile
  with Gufw to an special crafted file or path name wich contains shell
  code.

  reason is this line in ufw_backend.py :

  def export_profile(self, profile, file):
      commands.getstatusoutput('cp /etc/gufw/' + profile + '.profile ' + file + ' ; chmod 777 ' + file)

  The rename and delete funktions are also unsave if profile name
  contains shell code, like semicolons.

To manage notifications about this bug go to:
https://bugs.launchpad.net/gui-ufw/+bug/1410839/+subscriptions