gufw-developers team mailing list archive

[Bernd Dietzel <1410839@xxxxxxxxxxxxxxxxxx>]

OK, works fine !

the try and except was an good idea :-)

I have not purged the gufw because my mate-desktop would be also purged when i would do that.
It was not nessesary to purge , patches works , no shell command injection any more, no renaming problems.

Thank you !

-- 
You received this bug notification because you are a member of Gufw
Developers, which is subscribed to Gufw.
https://bugs.launchpad.net/bugs/1410839

Title:
  Shell Command injection in ufw_backend.py

Status in Gufw:
  Fix Committed

Bug description:
  Firewall Administrators can be tricked by someone to export a profile
  with Gufw to an special crafted file or path name wich contains shell
  code.

  reason is this line in ufw_backend.py :

  def export_profile(self, profile, file):
      commands.getstatusoutput('cp /etc/gufw/' + profile + '.profile ' + file + ' ; chmod 777 ' + file)

  The rename and delete funktions are also unsave if profile name
  contains shell code, like semicolons.

To manage notifications about this bug go to:
https://bugs.launchpad.net/gui-ufw/+bug/1410839/+subscriptions