← Back to team overview

gufw-developers team mailing list archive

[Bug 1410839] Re: Shell Command injection in ufw_backend.py

 

@Bernd, I owe you a beer ;P
I was reviewing the code and I found another shell injection in the IP & Ports :(
I'm attaching the patchs for all the affected versions and I'm sending the new version 15.04.2 to the maintainers.
Best regards and thanks Bernd!

** Patch removed: "Patchs for Gufw 14.04.2 & 14.10.1"
   https://bugs.launchpad.net/gui-ufw/+bug/1410839/+attachment/4301088/+files/patchs_14.04.2_and_14.10.1.tar.gz

** Attachment added: "patchs.tar.gz"
   https://bugs.launchpad.net/gui-ufw/+bug/1410839/+attachment/4301935/+files/patchs.tar.gz

-- 
You received this bug notification because you are a member of Gufw
Developers, which is subscribed to Gufw.
https://bugs.launchpad.net/bugs/1410839

Title:
  Shell Command injection in ufw_backend.py

Status in Gufw:
  Fix Released
Status in gui-ufw package in Ubuntu:
  Confirmed

Bug description:
  Firewall Administrators can be tricked by someone to export a profile
  with Gufw to an special crafted file or path name wich contains shell
  code.

  reason is this line in ufw_backend.py :

  def export_profile(self, profile, file):
      commands.getstatusoutput('cp /etc/gufw/' + profile + '.profile ' + file + ' ; chmod 777 ' + file)

  The rename and delete funktions are also unsave if profile name
  contains shell code, like semicolons.

To manage notifications about this bug go to:
https://bugs.launchpad.net/gui-ufw/+bug/1410839/+subscriptions


References