gwibber-bugs team mailing list archive

[Bilal Shahid <s9iper1@xxxxxxxxx>]

"Thanks for your patch, unfortunately our busy developers haven't been
able to review your patch in a timely manor. The gwibber codebase has
seen significant change and it is likely this patch no longer applies.
Please review it again and if it is still applicable, update it to work
with the latest gwibber trunk. We will be doing a patch review day in
the next few weeks and would like to review your patch. Thanks again for
your contribution!"

** Tags added: patch-day-old

** Changed in: gwibber
       Status: Triaged => Incomplete

-- 
You received this bug notification because you are a member of Gwibber
Bug Heros, which is subscribed to Gwibber.
https://bugs.launchpad.net/bugs/316198

Title:
  html entities for left/right double quotation mark shown in twitter
  feed

Status in Gwibber:
  Incomplete

Bug description:
  The issue can be seen here:
  http://www.prism.gatech.edu/~gtg031s/files/images/html_entity.png

  The attached patch fixed the problem, but it hasn't been fully tested.
  It only converts character references, so I don't think it will break anything in the html_string, but I could be wrong.
  I'm not sure why the character reference wasn't rendered in WebKit properly, and that is a much more difficult problem to solve.

  The unescape function could probably be pushed out to
  post_process_message, but I'm not sure how other protocols format
  their text.

  Once patched, the tweet renders as expected:
  http://www.prism.gatech.edu/~gtg031s/files/images/html_entity_fixed.png

To manage notifications about this bug go to:
https://bugs.launchpad.net/gwibber/+bug/316198/+subscriptions