harvest-dev team mailing list archive

[Dylan McCall <dylanmccall@xxxxxxxxx>]

Try rebasing it. Maybe it's Launchpad being funny about potential merge conflicts :)

Thanks for doing that with the url templatetag. It helps to separate the front end from the rest, which should serve us well in the future :)
It looks right to me!


I am not a huge fan of line 124:

  (<a href="{% url opportunity_detail opportunity.id %}edit?next={{request.get_full_path}}">edit</a>)

The hard-coded “edit” added to the end is asking for trouble. Would be nice to have a separate opportunity_edit URL. I think there is a templatetag somewhere to append GET parameters a bit more elegantly, too, although that isn't so much of an issue…

The same was there before, though, so we can just put it on the list of little things that don't really _need_ to be fixed, but would be satisfying to do :)
-- 
https://code.launchpad.net/~dholbach/harvest/581724/+merge/26959
Your team harvest-dev is requested to review the proposed merge of lp:~dholbach/harvest/581724 into lp:harvest.