harvest-dev team mailing list archive

[Dylan McCall <dylanmccall@xxxxxxxxx>]

The proposal to merge lp:~dylanmccall/harvest/bug-627601 into lp:harvest has been updated.

Description changed to:

First, sorry about the now missing merge referring to bug #722947. I ended up using the wrong bug report in the commit, the branch name and the merge request. Decided that was just a little too much wrongness so I started fresh.

This fixes a slightly simpler problem: harvest.js now acts on error messages while doing XHR stuff, fixing bug #627601. This branch depends on the branding change because there was a nearby change in base.html and I didn't want to subject anyone to the merge conflict. If that isn't merged, we can change this fairly quickly.

Since this adds a string people might read, I moved it and another string from harvest.js to base.html so they can be localized neatly with everything else.

Since the server code is invincible (:b), the quickest way to make it fail for testing this is to edit harvest/opportunities/filters.py and add under process_queryset (line 9) something like this:

raise Exception("Disaster!", "Panic!")

This way you'll get a server error when you enable the package name filter. It should look something like this:
http://people.ubuntu.com/~dylanmccall/harvest/bugs/lp627601/Fix-HarvestJsError.png

For more details, see:
https://code.launchpad.net/~dylanmccall/harvest/bug-627601/+merge/59876
-- 
https://code.launchpad.net/~dylanmccall/harvest/bug-627601/+merge/59876
Your team harvest-dev is requested to review the proposed merge of lp:~dylanmccall/harvest/bug-627601 into lp:harvest.