← Back to team overview

hipl-core team mailing list archive

[Branch ~hipl-core/hipl/trunk] Rev 4899: Set 'cast discards qualifiers' to be treated as an error

 

------------------------------------------------------------
revno: 4899
committer: Artturi Karila <artturi.karila@xxxxxxxxxx>
branch nick: trunk
timestamp: Thu 2010-08-19 12:40:48 +0300
message:
  Set 'cast discards qualifiers' to be treated as an error
  
  Removed the now obsolete --enable-gcc-warn option.
modified:
  configure.ac


--
lp:hipl
https://code.launchpad.net/~hipl-core/hipl/trunk

Your team HIPL core team is subscribed to branch lp:hipl.
To unsubscribe from this branch go to https://code.launchpad.net/~hipl-core/hipl/trunk/+edit-subscription
=== modified file 'configure.ac'
--- configure.ac	2010-08-18 13:05:50 +0000
+++ configure.ac	2010-08-19 09:40:48 +0000
@@ -75,7 +75,7 @@
 AC_SUBST(AM_CFLAGS, "$AM_CFLAGS -Wredundant-decls -Wdisabled-optimization")
 AC_SUBST(AM_CFLAGS, "$AM_CFLAGS -Wundef -Wstrict-prototypes -Wmissing-prototypes")
 AC_SUBST(AM_CFLAGS, "$AM_CFLAGS -Wno-deprecated-declarations -Wpointer-arith")
-AC_SUBST(AM_CFLAGS, "$AM_CFLAGS -Wwrite-strings -Wshadow -Winline")
+AC_SUBST(AM_CFLAGS, "$AM_CFLAGS -Wwrite-strings -Wshadow -Winline -Wcast-qual")
 
 
 #TODO fix the code and get rid of this one
@@ -84,20 +84,6 @@
 # Set the preprocessor flags for the entire project
 AC_SUBST(AM_CPPFLAGS, "-D_POSIX_C_SOURCE=200112L -D_XOPEN_SOURCE=500")
 
-
-# The flags below should be converted into errors once all warnings are fixed.
-AC_ARG_ENABLE(gcc-warn,
-               AS_HELP_STRING([--enable-gcc-warn],
-                              [enables additional compiler warnings (default is YES)]),
-               [ac_cv_use_gcc_warn=$enableval],
-               [ac_cv_use_gcc_warn=yes])
-AC_CACHE_CHECK([whether to use gcc-warn],
-               [ac_cv_use_gcc_warn],
-               [ac_cv_use_gcc_warn=yes])
-if test x"$ac_cv_use_gcc_warn" = x"yes"; then
-    AC_SUBST(AM_CFLAGS, "$AM_CFLAGS -Wcast-qual -Wno-error=cast-qual")
-fi
-
 AC_ARG_ENABLE(firewall,
                AS_HELP_STRING([--enable-firewall],
                               [HIP enabled firewall daemon (default is YES)]),