hipl-core team mailing list archive

[Mircea Gherzan <mircea.gherzan@xxxxxxxxxxxxxx>]

Hi,

Diego Biurrun <diego@xxxxxxxxxx> wrote:
> The subject line you send is a slight improvement, the body of the
> message is IMO not.  It no longer contains all the useful information
> that launchpad puts above the diff.

The information launchpad puts above the diff:
* revno - part of the subject
* committer - From: field
* branch nick - part of the subject
* timestamp - do we really need second accuracy?
* message - still there
* modified - can be seen in the diff itself

> > #!/bin/sh  
> 
> > # get the HEAD revision (the last one)
> > head=`bzr log | head -2 | tail -1 | cut -f 2 -d ' '`  
> 
> bzr revno

Nice :)

> Also, $() is better than ``, it's easier to nest, same below.

True.
 
> > # lastrev was already processed, so incrementing it
> > lastrev=`expr $lastrev + 1`  
> 
> $(($lastrev + 1))

Is this POSIX scripting or is it a bash-ism?

> > 	# create the body of the e-mail
> > 	true > $MAILBUF  
> 
> 'true' unneeded.

Again, is this POSIX?

Thanks,
Mircea


-- 
Dipl.-Ing. Mircea Gherzan

Attachment: signature.asc
Description: PGP signature