← Back to team overview

hipl-core team mailing list archive

Re: [Branch ~hipl-core/hipl/trunk] Rev 4915: More verbose debug messages.


On Sat, Aug 28, 2010 at 06:32:50PM +0200, Christof Mroz wrote:
> On Sat, 28 Aug 2010 15:49:21 +0200, Diego Biurrun <diego@xxxxxxxxxx> wrote:
>>> OK; it's 8 spaces, right?
>> No, you should indent smartly, not mechanically.  It should be described
>> in the HACKING files of both PISA and HIPL.  Have you read them?
> Yes but obviously not thoroughly enough :) didn't notice there's a  
> distinction between assignments and function calls regarding indention.

How can this be made clearer?

> Did I get it right this time?

Define "right".  The patch you attached is not an indentation fix.
Looks fine at a glance though.


Follow ups