hipl-core team mailing list archive

[noreply@xxxxxxxxxxxxx]

------------------------------------------------------------
revno: 4945
committer: Christof Mroz <christof.mroz@xxxxxxxxxxxxxx>
branch nick: hipfw-performance
timestamp: Wed 2010-09-15 19:33:43 +0200
message:
  Add reminders concerning performance.
modified:
  firewall/firewall.c


--
lp:~christof-mroz/hipl/hipfw-performance
https://code.launchpad.net/~christof-mroz/hipl/hipfw-performance

Your team HIPL core team is subscribed to branch lp:~christof-mroz/hipl/hipfw-performance.
To unsubscribe from this branch go to https://code.launchpad.net/~christof-mroz/hipl/hipfw-performance/+edit-subscription

=== modified file 'firewall/firewall.c'
--- firewall/firewall.c	2010-09-13 14:26:58 +0000
+++ firewall/firewall.c	2010-09-15 17:33:43 +0000
@@ -1406,6 +1406,9 @@
  * Initialize the firewall datastructures and ipqueue rules
  *
  * @return zero on success or non-zero on failure
+ *
+ * @todo performance: consider packet marking to save lookups
+ *                    (e.g. in LSI, Relay).
  */
 static int firewall_init(void)
 {
@@ -1917,7 +1920,9 @@
  *
  * @return zero on success and non-zero on failure
  *
- * @todo   Set up atexit() for clean shutdown on HIP_ASSERT.
+ * @todo Set up atexit() for clean shutdown on HIP_ASSERT.
+ * @todo performance: epoll() should be quicker than select() on linux;
+ *                    test this.
  */
 int main(int argc, char **argv)
 {