holland-coredev team mailing list archive

[Andrew Garner <668161@xxxxxxxxxxxxxxxxxx>]

I don't think it makes sense for holland to run perror here.  Many
errors will just bloat the logs or make them more confusing, I think.
Namely for instance:

mysqldump: Couldn't execute 'show create table `v_foo`': View
'test.v_foo' references invalid table(s) or column(s) or function(s) or
definer/invoker of view lack rights to use them (1356)

# perror 1356
MySQL error code 1356 (ER_VIEW_INVALID): View '%-.192s.%-.192s' references invalid table(s) or column(s) or function(s) or definer/invoker of view lack rights to use them

That's not friendlier at all.  Perhaps for the LOCK TABLES case it's
slightly nicer, but I don't think it's worth the extra effort.

** Changed in: holland-backup
       Status: Confirmed => Won't Fix

-- 
You received this bug notification because you are a member of Holland
Build, which is subscribed to holland-backup.
https://bugs.launchpad.net/bugs/668161

Title:
  Failures log perror output

Status in Holland Backup Framework:
  Won't Fix

Bug description:
  It would be a useful feature for Holland to log perror output in cases
  where a backup fails.  Currently, it will log a failed backup due to a
  crashed table as follows:

  2010-10-28 19:27:27,520 [ERROR] /usr/bin/mysqldump[4773]: mysqldump:
  Got error: 1016: Can't open file: 'post.MYI' (errno: 145) when using
  LOCK TABLES

  It would be nice if it could capture errno and run it through perror
  so that you end up seeing:

  2010-10-28 19:27:27,520 [ERROR] /usr/bin/mysqldump[4773]: mysqldump: Got error: 1016: Can't open file: 'post.MYI' (errno: 145) when using LOCK TABLES
  2010-10-28 19:27:27,520 [INFO]  MySQL error code 145: Table was marked as crashed and should be repaired

To manage notifications about this bug go to:
https://bugs.launchpad.net/holland-backup/+bug/668161/+subscriptions