← Back to team overview

holland-coredev team mailing list archive

[Bug 1256121] Re: parse failures of lvs output in locales other than "C"

 

Thanks for the report and fix. Yeah, I see this comes from -o
snap_percent which uses "," as the decimal mark in certain locales and
holland also unfortunately uses the ',' as the lvs --separator.  I'll
make sure this gets added as some sort of regression test.

Forcing the locale is likely safe enough for the lvm commands.  However,
perhaps fixing the parsing by adjusting the --separator option makes
sense here as well (e.g. the equivalent of lvs [options] --separator
$'\t')


** Changed in: holland-backup
     Assignee: (unassigned) => Andrew Garner (muzazzi)

** Changed in: holland-backup
    Milestone: None => 1.0.12

** Changed in: holland-backup
   Importance: Undecided => Critical

** Changed in: holland-backup
       Status: New => In Progress

-- 
You received this bug notification because you are a member of Holland
Build, which is subscribed to holland-backup.
https://bugs.launchpad.net/bugs/1256121

Title:
  parse failures of lvs output in locales other than "C"

Status in Holland Backup Framework:
  In Progress

Bug description:
  To test the failure try to use mysqldump-lvm and set your LANG e.g. to
  de_DE.utf8

  In this case the value of vg_name will be filled with the incorrect
  value of modules which leads to a LoockupError when executing blkid on
  a wrong dev path.

  The atteched patch fixes the problem for me :)

To manage notifications about this bug go to:
https://bugs.launchpad.net/holland-backup/+bug/1256121/+subscriptions


References