hugin-bug-hunters team mailing list archive
-
hugin-bug-hunters team
-
Mailing list archive
-
Message #00071
[Bug 679412] Re: problems with __unix__ define on max osx
This has been solved somewhere february/march 2010
** Changed in: hugin
Status: New => Fix Released
--
problems with __unix__ define on max osx
https://bugs.launchpad.net/bugs/679412
You received this bug notification because you are a member of Hugin Bug
Hunters, which is subscribed to Hugin.
Status in Hugin - Panorama Tools GUI: Fix Released
Bug description:
When running on a Mac the generated makefile contains certain windowisms, the most obvious being the redirection of STDOUT to NUL rather than /dev/null. It turns out that hugin/src/hugin_base/algorithms/panorama_makefile/PanoramaMakefileExport.cpp makes that assumption that if __unix__ is not defined then hugin is being compiled for windows. I suspect this problem causes other more subtle bugs elsewhere in the hugin code base.
I notice the following code snippet in hugin/src/hugin_base/hugin_utils/platform.h
#ifndef UNIX_LIKE
#if __unix__ || MAC_OS_X
// __unix__ is not defined on Mac, but Mac is a BSD
#define UNIX_LIKE 1
#endif
#endif
so I suspect a quick s/__unix__/UNIX_LIKE/ would resolve this. I could have a go at producing a patch, but as I've not yet attempted to build hugin from source it might take me some time. Is there anybody who can have a look at this?