hugin-bug-hunters team mailing list archive

Thread
Date

[Bug 679718] Re: Better exception handling for deghosting tools

To: hugin-bug-hunters@xxxxxxxxxxxxxxxxxxx
From: Yuv <679718@xxxxxxxxxxxxxxxxxx>
Date: Fri, 26 Nov 2010 18:53:11 -0000
Reply-to: Bug 679718 <679718@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx

** Tags added: patch

** Changed in: hugin
     Assignee: (unassigned) => Lukas Jirkovsky (l-jirkovsky)

** Changed in: hugin
       Status: New => Triaged

-- 
Better exception handling for deghosting tools
https://bugs.launchpad.net/bugs/679718
You received this bug notification because you are a member of Hugin Bug
Hunters, which is subscribed to Hugin.

Status in Hugin - Panorama Tools GUI: Triaged

Bug description:
what() function in BadDimensions and NoImages classes should be 'const' to override std::exception's what() properly.
patch-src-tools-hugin_hdrmerge.cpp.diff contains also quick&dirty hack to restore alpha channel in image produced by khan algorithm. This isn't "Right Way", but allows to use combined image stacks with enblend. Just IMHO, Deghosting class shouldn't check input images dimensions in loadImages() functions. An overlapping rectangle should be calculated using input images bitmap sizes, page offsets and alpha channels. Sizes and offsets of this rectangle should be used as sizes and offsets of output image. Alpha channel of output image should be made as intersection or joining of input images alpha channels.