← Back to team overview

hugin-bug-hunters team mailing list archive

[Bug 2122202] Re: build error against cmake 4

 

Thanks, both issues should be fixed in the repository: 937:698e20b4d296
& 938:6b0f2a5ef7a0

** Changed in: panotools
       Status: New => Fix Committed

-- 
You received this bug notification because you are a member of Hugin Bug
Hunters, which is subscribed to Panotools.
https://bugs.launchpad.net/bugs/2122202

Title:
  build error against cmake 4

Status in Panotools:
  Fix Committed

Bug description:
  libpano 2.9.22 FTBFS against cmake 14.

  
  CMake Error at CMakeLists.txt:32 (cmake_minimum_required):
    Compatibility with CMake < 3.5 has been removed from CMake.

    Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
    to tell CMake that the project requires at least <min> but has been updated
    to work with policies introduced by <max> or earlier.

  Easily fixed by 
  -# require at least cmake 3.0
  -cmake_minimum_required(VERSION 3.0)
  +# require at least cmake 3.50
  +cmake_minimum_required(VERSION 3.5)

  
  BTW: please note that this part

  # create TAGS file
  ADD_CUSTOM_COMMAND( OUTPUT ctags POST_BUILD
                     COMMAND ctags-exuberant -e *.c *.h tools/*.c
                     WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}/
                     COMMENT "Build TAGS file"
  is broken and triggers
  CMake Warning (dev) at CMakeLists.txt:386 (ADD_CUSTOM_COMMAND):
    The following keywords are not supported when using
    add_custom_command(OUTPUT): POST_BUILD.

    Policy CMP0175 is not set: add_custom_command() rejects invalid arguments.
    Run "cmake --help-policy CMP0175" for policy details.  Use the cmake_policy
    command to set the policy and suppress this warning.

  Afaiui POST_BUILD is only valid for the "add a custom command to a
  target" variant of add_custom_command().

  cu Andreas

To manage notifications about this bug go to:
https://bugs.launchpad.net/panotools/+bug/2122202/+subscriptions



References