hugin-devs team mailing list archive

[Gerry Patterson <683003@xxxxxxxxxxxxxxxxxx>]

Fix committed, change-set 4659:5e2111e8c9ac

** Changed in: hugin
       Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/683003

Title:
  Ouputmode is used wrong in mainFrame.cpp

Status in Hugin - Panorama Tools GUI:
  Fix Committed

Bug description:
  
I get: 

....src/hugin1/hugin/MainFrame.cpp:744: warning: case label value exceeds maximum value for type

742    PanoramaOptions opts = pano.getOptions();
743    switch (opts.outputMode) {
744        case PanoramaOptions::TIFF:
745        case PanoramaOptions::JPEG:
746        case PanoramaOptions::PNG:
747            opts.outputLDRBlended = true;
748            break;
749        default:
750            break;
751    }


The outputMode is defined as a enum that will have the values OUTPUT_LDR or ..HDR .  (0 or 1). 
The TIFF define is too large because it has value 2. It is ment for the FileFormat element of the structure. 

I'm not familiar enough (yet) with the code to implement a patch today. 

(Just change outputMode to "outputFormat" ?) 
-----------
version: Pre-Release 2010.4.0.1e3fcb26cf9e
OS: Ubuntu-Lucid. 

I'm tagging this "triaged" and "high", because I am pretty sure this is definitively wrong. 

I would suggest that someone checks his build. Around 65%, mainFrame.cpp is compiled, and the message appears. Please push to "confirmed" once this has been verified to occur with someone else too.