← Back to team overview

hugin-devs team mailing list archive

[Bug 678763] Re: Pano13: struct Image initialization error

 

Just checked the source, and except for a few lines movement the bug is
still there.

** Tags added: libpano patch source

** Attachment added: "Obvious editing error in the source fixed."
   https://bugs.launchpad.net/hugin/+bug/678763/+attachment/1754008/+files/libpano-patch

** Changed in: hugin
   Importance: Low => Medium

** Changed in: hugin
       Status: New => Confirmed

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/678763

Title:
  Pano13: struct Image initialization error

Status in Hugin - Panorama Tools GUI:
  Confirmed

Bug description:
  The Pano13 source in the hugin SDK has a typo in line 849 of filter.c, in function SetImageDefaults(). It reads
  bzero(im->formatParam, sizeof(im->precomputedValue));
but should be
  bzero(im->precomputedValue, sizeof(im->precomputedValue));

This leaves 4 of the precomputed values uninitialized since formatParam starts 4 words before precomputedValue and overwrites precomputedCount with (another) zero.  

Unlikely to cause malfunction.