← Back to team overview

hugin-devs team mailing list archive

Re: [Bug 679715] Re: improved localization

 

Hi Thomas,

On January 8, 2011 09:33:15 am tmodes wrote:
> Point 1: You are using INSTALL_LOCALE_DIR. This is a fixed absolute
> path, which does not work on Windows. A solution can be found now in
> lines 288ff in src/celeste/Main.cpp. It moved some lines since the last
> comment. So looking at the code, I see that this does also not work with
> the bundled Mac version.

Thank you for pointing me in the right direction.  I think I fixed this with 
my last commit.

 
> Point 2: e.g. in ImagesCaches.cpp you call twice
> 
> bindtextdomain( "hugin", INSTALL_LOCALE_DIR );
> textdomain( "hugin" );
> 
> This code is linux only and should be moved into an own function
> providing the platform specific part, see point 1

I moved it into its own function, although I am not sure that how I call that 
function from within ImageCache.cpp (line 510) is the right way of doing it.

I also realize that the changes to nona, which I did as well in the i18n 
branch, are not effective because I do not call that function.  I first 
thought that everything was called by the includes that I have moved into 
src/hugin_base/hugin_utils/utils.cpp - I forgot about the two lines you 
mention above.

Where should I put the call to hugin_utils::TranslateText() ?

Thank you for your feedback, it help me learn and understand coding.


> you need to check if wxWidgets own translation work together with the
> new introduced gettext lib translation in part of Hugin libaries or if
> there are cross over effects.

it seem to be working.  the only problem is an aesthetic one: wX translations 
are now in _() while non-wX translations are in _X()


> Concerning the links: They don't help further. Link 1 would introduce a dll
> -> dll hell. All other libraries in Hugin on Windows are static. Also the
> mentioned way does not provide the necessary files for linking the dll
> with Hugin. Link 2 is using a compiliation model which is incompatible
> with Hugin.

Sorry for that.  Do you have gettext working at all on your Windows machine 
(i.e. does this "only" make it for a more difficult SDK creation) or is this 
completely broken on Windows at this time?

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/679715

Title:
  improved localization

Status in Hugin - Panorama Tools GUI:
  Confirmed

Bug description:
  http://groups.google.com/group/hugin-ptx/msg/81964d82d72e6879





References