hugin-devs team mailing list archive
-
hugin-devs team
-
Mailing list archive
-
Message #00999
[Bug 696646] Re: Windows: incorrect quoting in Makefile generation
> Our assumption is that 'make' is using the wrong shell for some reason,
> i.e. it is told to use cmd.exe but uses the cygwin sh.exe instead.
I tested with different makefile:
First the current implementation used by hugin (SHELL variable quoted for shell):
SHELL="c:/windows/system32/cmd.exe"
all:
@echo ${SHELL}
make -f test.mk outputs:
SHELL is sh.exe
which is obviously wrong.
Removing the quotes (SHELL=c:/windows/system32/cmd.exe) results in correctly output:
SHELL is c:/windows/system32/cmd.exe
And now a last try with SHELL=c:\windows\system32\cmd.exe (with windows path separators and without quotes) gives the same output.
So gnu make processes the SHELL variable different than others
So I modified the makefile generation to the last variant (commited as
efade34da4f6). Hopefully this fixes the issue of selecting the wrong
shell.
> Alternatively it could be that Hugin is unintentionally running the
> cygwin make.exe instead of the shipped win32 make.exe, this would
> explain why it is incapable of finding cmd.exe.
This can not be happen. Hugin is always using make.exe in hugins path.
--
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/696646
Title:
Windows: incorrect quoting in Makefile generation
Status in Hugin - Panorama Tools GUI:
Incomplete
Bug description:
Reported on Hugin-PTX http://groups.google.com/group/hugin-
ptx/t/d33b5bc24aada66b
HuginSetup_2010.4.0-64bit_Windows.exe on my Windows 7 x64. Everything work fine, until i try to
create the pano. Then i got the following message:
[...]
===========================================================================
System information
===========================================================================
/usr/bin/sh: -c: line 1: syntax error near unexpected token `(6'
/usr/bin/sh: -c: line 1: `echo Operating System: Windows 7 (6.1 )'
make: *** [info] Error 258
Makefile attached. Obviously lacking quotes in the info target around
line 211.
References