hugin-devs team mailing list archive

[Yuv <679753@xxxxxxxxxxxxxxxxxx>]

Hi Vladimir,

I added your patches to a new branch in the repository so that they can
be more widely tested / improved by the community.  I will be announcing
it on Hugin-PTX shortly.

http://hugin.hg.sourceforge.net/hgweb/hugin/hugin/rev/36e7649cf137


Some feedback:

patch4 works for align_image_stack but not for HDR panoramas in Hugin.
If I read your patch correctly, you introduced a boolean variable,
'intersection', to identify if the point must be inside a whole stack of
images; or if it merely must be inside a single image.  However the test
is for the point to be inside all images, and not inside a stack.
align_image_stack is a special case in that there is only one stack.
The general case of an HDR panorama has multiple stacks; and to fix bug
#679981 the test would need to be limited to each single stack
separately; as opposed to all images (= all stacks).

Instead of iterating all images with

for(UIntSet::const_iterator
it=activeImages.begin();it!=activeImages.end();it++)

you want to iterate all stacks; and within each stack run the
inside/outside test.

The above is an approximation, though it may be good enough.  It assumes
that the stacks are perfectly aligned and might miss on some marginal
pixels with hand held input.

To do it perfectly, you would want to iterate all images within an
exposure layer and make sure the point is inside each exposure layer,
but this has its limitations as well if the camera was on auto-exposure:
the result would depend on the definition of the EV range to be
considered a single layer.  I personally would try first to iterate the
stacks.

Last but not least, next time you produce a patch can you simply use `hg
diff > patch.file` to generate it?  your patch file did not have the
full path information for the patched files, requiring more manual work
than necessary to apply them.

Thank you again for your contribution
Yuv

** Changed in: hugin
       Status: Triaged => In Progress

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/679753

Title:
  Stereo images alignment

Status in Hugin - Panorama Tools GUI:
  In Progress

Bug description:
  Hi,
  I tried to use align-image-stack for processing stereo images (taken from slightly different angle). Here are the modifications that I did:

  1. Two-phase control point matching - the patch adds second phase,
  where the points are fine-tuned on full-size image. This gives better
  results with comparable speed.

  2. stereo mode - the points are optimized only for Y (horizontal
  line). Horizontal shift of the control points is allowed. One vertical
  line is added to anchor the horizontal shift of the images. The patch
  also adds options to optimize distortion and image center shift.

  3. extra control points around the image edges - in stereo mode the image edges are interesting for "stereo window" alignment. The normal method generated too few control points near the edges. This patch forces additional points, which are then filtered by correlation and geometric pruning.
  I want to work on automatic "stereo window" alignment in the future.