← Back to team overview

hugin-devs team mailing list archive

[Bug 721156] Re: left image margin shows though image is totally masked

 

I'm not happy with your 'won't fix' decision, and for several reasons:

1. sloppy maths will eventually backfire, usually when you most need
them.

2. It's not a matter of sub-pixel accuracy but of one pixel accuracy.
The one-pixel-wide part of the resulting image does, in my case, occur
in regions of the output which are up to several thousand pixels away
from any other content. This has the effect of including all content
between the one-pixel-feature and the remainder of the image into the
output, generating loads of totally unneeded data.

3. I'm not drawing these masks by hand, but I'm automatically generating
them in a script. This bug burdens me with polluting my code with stuff
like 'if the mask happens to coincide with the left image margin, move
it one pixel to the left to avoid the hugin masking bug'. This is ugly.

4. You saw my observation and could reproduce it. The behaviour of the
code is wrong, never mind one can work around the issue. I feel it would
have been proper to leave the bug open at low priority rather than
simply deciding that it's not going to be fixed at all. If it dies of
old age because noone cares about fixing it, so be it.

Kay

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/721156

Title:
  left image margin shows though image is totally masked

Status in Hugin - Panorama Tools GUI:
  Won't Fix

Bug description:
  I noticed what I think is faulty mask processing on images where a mask boundary coincides with the left image boundary. I have managed to produce a very simple demonstartion of the behaviour with the enclosed files. The pto contains a single monochrome image with a mask of precisely the same dimensions, and one would assume that this should render the whole image invisible. But in the previews and in the final output, a narrow strip of the image's left margin still shows. In the pto I have attached I have centered on this and chosen a small FOV to make this well visible - if you can reproduce the bug it would show as a vertical malachite band in the preview. The attached file contains input image, pto and output image - since the images are jpg and very small, I took the liberty to attach them as well. Notice that I manually edited the k-line in the pto to position the mask precisely on the image boundaries.
  I noticed this using Pre-Release 2010.5.0.5a0bdb77823c, self-compiled on Kubuntu 10.10, but I've seen it earlier as well and was never bothered enough to send in a bug report. I think it only occurs if the left margin coincides with the mask and the remainder of the mask can be any shape.
  Kay



References