← Back to team overview

hugin-devs team mailing list archive

[Bug 721156] Re: left image margin shows though image is totally masked

 

Hi Yuval!

Sorry, I didn't see your comment until today. I wouldn't call it asking
for a new feature. It's as I said in my original report: If you mask an
image with a mask that has it's left margin set to zero, you'd expect
the masked image to be rendered totally invisible. But some of the image
still shows, like I have demonstrated im my attached files. If you set
the left margin of the mask to -1, the image is finally invisible as it
should hav been in the first place. Note that the effect only occurs on
the left margin, not top, bottom or right margin - this is why I suspect
sloppy maths.

In my script, I now use a workaround for the left-margin-is-zero-case
with a note attached why this has to be done. It's ugly but it works.
Still I'd be happier if the masking code were mathematically correct.

I only kept moaning about the issue because of Thomas' 'won't fix'
decision which I felt was the wrong way to deal with it.

Kay

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/721156

Title:
  left image margin shows though image is totally masked

Status in Hugin - Panorama Tools GUI:
  Won't Fix

Bug description:
  I noticed what I think is faulty mask processing on images where a mask boundary coincides with the left image boundary. I have managed to produce a very simple demonstartion of the behaviour with the enclosed files. The pto contains a single monochrome image with a mask of precisely the same dimensions, and one would assume that this should render the whole image invisible. But in the previews and in the final output, a narrow strip of the image's left margin still shows. In the pto I have attached I have centered on this and chosen a small FOV to make this well visible - if you can reproduce the bug it would show as a vertical malachite band in the preview. The attached file contains input image, pto and output image - since the images are jpg and very small, I took the liberty to attach them as well. Notice that I manually edited the k-line in the pto to position the mask precisely on the image boundaries.
  I noticed this using Pre-Release 2010.5.0.5a0bdb77823c, self-compiled on Kubuntu 10.10, but I've seen it earlier as well and was never bothered enough to send in a bug report. I think it only occurs if the left margin coincides with the mask and the remainder of the mask can be any shape.
  Kay



References