← Back to team overview

hugin-devs team mailing list archive

Re: [Bug 806153] Re: Autocrop doesn't always work

 

On August 11, 2011 04:19:33 pm Henk Tijdink wrote:
> I did some more investigation

Thank you for all the investigation.  Based on your feedback I was able to 
identify / explain what happened.

Toward the end of the 2010.2 autocrop was activated blindly for all 
projections.  This was also applied to the default branch in 4402 and 4406.  
However later on a function has been introduced to return if the fov 
calculation is supported.

fovCalcSupported(<projection>).  This limits the list of projection under 
which fov calculation is supported in the fast preview but has not been 
implemented in the stitcher panel (reference to self:  should go in around 
line 379 of PanoPanel.cpp).

So you may have definitely zeroed in on a bug; and maybe even on two:
1) we need to apply the fovCalcSupport limit to the Stitcher tab; and maybe we 
need to extend the list of what is supported on fovCalcSupport.

Before extending the list, we need to make sure that the problem is not just 
that the button is not grayed out, but that the calculation actually works.  
Can you please test some autocrops on these projections?

Thanks

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/806153

Title:
  Autocrop doesn't always work

Status in Hugin - Panorama Tools GUI:
  Confirmed

Bug description:
  In Hugin 2011.2.0 beta 1 for windows(2011.2.0.cf0eaefbe0dd built by Matthew Petroff) I found after extensive testing the following probably related bugs.
  My system windows XP incl. servicepack 3.

  1) In the fast preview window the autocrop function doesn't work with
  the following projections:

  Fisheye
  Stereo
  Transmercator
  Both Lambert projections
  Albers
  Orthographic
  Equisolid
  Thoby.

  But under the Stitcher Tab the fit crop works for that projections.

  2) Under the Stitcher tab the function calculate optimal size doesn't
  work for projections mentioned under 1).

To manage notifications about this bug go to:
https://bugs.launchpad.net/hugin/+bug/806153/+subscriptions


References