hugin-devs team mailing list archive

[Christoph Spiel <cspiel@xxxxxxxxxx>]

THX for your thorough analysis!  I'm willing to apply all of your patches,
however only #1 applies cleanly against the head of the development
branch.  Could you please be so kind and rework the others?  Our
development policy is to test all changes in the development branch
before migrating any of them to the stable branch.


** Changed in: enblend
       Status: New => In Progress

** Changed in: enblend
   Importance: Undecided => Low

** Changed in: enblend
     Assignee: (unassigned) => Christoph Spiel (cspiel)

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Enblend.
https://bugs.launchpad.net/bugs/1332323

Title:
  Fix issues reported by valgrind

Status in Enblend:
  In Progress

Bug description:
  Hi everyone,

  I ran enblend under valgrind which reported several issues.

  The first one is a simple missing initialization.

  The other ones are mostly about bad usage of boost::scoped_ptr<>. I have two 
  different approaches to fix this:

  1. Directly write into std::string buffer instead of using a temporary char[] 
  buffer. This is guaranteed behavior by C++11, see e.g.
  http://herbsutter.com/2008/04/07/cringe-not-vectors-are-guaranteed-to-be-contiguous/#comment-483

  2. Use a boost::tokenizer. As it does not need a char[] buffer, different to
  strtok, no need to allocate one. This has the nice side effect to get rid
  of the homegrown enblend::strtoken_r tokenizer.

  Kind regards,

  Stefan

To manage notifications about this bug go to:
https://bugs.launchpad.net/enblend/+bug/1332323/+subscriptions