hugin-devs team mailing list archive

[Christoph Spiel <cspiel@xxxxxxxxxx>]

Thanks for rebasing the three remaining patches!

Applied "Fix_wrong_usage_of_std__unique_ptr__new_vs_new__.diff" in rev e4c9714f879a,
"Use_boost__tokenizer_instead_of_homegrown_tokenizer__fix_bad_unique_ptr.diff" in rev 3f45ce5f3ac3,
and "Use_stack_allocated_CheckpointPixels_instead_of_unique_ptr_tracked_one_.diff" in rev c9d5669c59a2.

Keep those high-quality patches coming.

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Enblend.
https://bugs.launchpad.net/bugs/1332323

Title:
  Fix issues reported by valgrind

Status in Enblend:
  Fix Committed

Bug description:
  Hi everyone,

  I ran enblend under valgrind which reported several issues.

  The first one is a simple missing initialization.

  The other ones are mostly about bad usage of boost::scoped_ptr<>. I have two 
  different approaches to fix this:

  1. Directly write into std::string buffer instead of using a temporary char[] 
  buffer. This is guaranteed behavior by C++11, see e.g.
  http://herbsutter.com/2008/04/07/cringe-not-vectors-are-guaranteed-to-be-contiguous/#comment-483

  2. Use a boost::tokenizer. As it does not need a char[] buffer, different to
  strtok, no need to allocate one. This has the nice side effect to get rid
  of the homegrown enblend::strtoken_r tokenizer.

  Kind regards,

  Stefan

To manage notifications about this bug go to:
https://bugs.launchpad.net/enblend/+bug/1332323/+subscriptions