← Back to team overview

hugin-devs team mailing list archive

[Bug 1374686] Re: Enblend adds black to edges of some pictures in a pano sometimes when using include masks.

 

Revision 8f4a08e6a317 should restore total correctness
    http://hg.code.sf.net/p/enblend/code/rev/8f4a08e6a317

Now, Enblend will abort if it encounters a near-overlap that
its algorithm is not able to handle.

We are not as strict as we could be, but most problems
should be caught by the new check.  However, the borders
of the black alpha mask's are still untested.

You can play with the check's threshold parameter to fit it
to your images.  Let us know, whether we ought to adapt
the default.


** Changed in: enblend
       Status: New => Fix Committed

** Changed in: enblend
   Importance: Undecided => Medium

** Changed in: enblend
     Assignee: (unassigned) => Christoph Spiel (cspiel)

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Enblend.
https://bugs.launchpad.net/bugs/1374686

Title:
  Enblend adds black to edges of some pictures in a pano sometimes when
  using include masks.

Status in Enblend:
  Fix Committed

Bug description:
  Here are two examples http://kvtours.com/test-photos/CraterLake.jpg
  and
  http://kvtours.com/test-photos/Wheeler1.jpg

  
  http://kvtours.com/test-photos/enblendBlackEdgeErrorTest.zip That is a 8.12mb test package for use with hugin. 

  The test package is an example that I just took out of a half pano
  that I was working on last nightt, that I doubt many people would have
  cause to do, but it was an easy one to show the problem with. In it
  you will find two pictures and a pto file. One of the pictures is in
  the pto file twice. The second copy has different light settings so
  that the sun is not quite so blown out. There is complete overlap on
  those two images. When I put a single include mask on the one that has
  a good sun I get a pretty good result, but the mask goes a bit further
  away from the sun than I want. So I add a second include mask to the
  other copy to keep most of the good colors and then I get the results
  shown in the Wheeler1.jpg

  If I remove one of the include masks and instead use one include and
  one exclude I get the results that I want with no bugs. Remove both
  masks it works as expected as well.


  On the crater lake one I did it a month ago and it more clearly shows
  the problem(I did not include it as a test package as it is a large
  set). My work flow on it, I was going along stitching small versions
  finding places where there were masking errors or that I needed more
  control points and correcting as I saw fit and then somewhere along
  the lines the black started showing up. At first it was just a little
  bit on the rock under the tri-pod. That caught my eye and I removed
  all the masks in that area and restitched. That did not remove the
  problem(I still had masks in other places.) I figured I could
  photoshop it so I continued and a few masks and restitches later I had
  problems showing up in places where there were and had never been a
  mask(that is the photo that I attached to this post). At that point I
  scrapped the project and started over and had no problems on my second
  try.

  
  I have seen the bug with both the version of enblend that comes with hugin 2013 and enblend 4.1.3 win64 version. 

  I am running windows 7 on a desktop. A friend has had the same
  problems with windows 7 on a laptop.

  For command line options I use the standard that hugin has plus I add in
  -a --no-ciecam

  Here is the thread where I first started talking about it.
  https://groups.google.com/forum/#!msg/hugin-ptx/pQYSIjk7Af8/WyYBRSz_CgMJ

To manage notifications about this bug go to:
https://bugs.launchpad.net/enblend/+bug/1374686/+subscriptions


References