hugin-devs team mailing list archive

[Jan Dubiec <1495365@xxxxxxxxxxxxxxxxxx>]

A few comments about your version of my patch:
1. It seems that log(1+x) has issues for small x: http://www.boost.org/doc/libs/1_59_0/libs/math/doc/html/math_toolkit/powers/log1p.html what, I believe, is the reason why log1p() has been introduced into C and C++ standards. So why not use Boost's log1p() if Boost is used anyway?
2. std::sqrt() for integral arguments is C++11 feature (http://en.cppreference.com/w/cpp/numeric/math/sqrt) so it is not supported by VC++ 2010.

Yeah, I use an ancient compiler because I haven't been able to build
Hugin with MinGW-W64's gcc-5.1.0 - I've got some linker, Unicode &
windows.h related issues. So I (quite easily) managed to build
Hugin.2015.0 and default branch using VC++ 2010. But my goal is to build
Hugin on Windows using latest versions of gcc . And, by the way, clean-
up some mess in the code (eg. IMO macros _WIN32, WIN32 and _WINDOWS are
used inconsistently).

BTW. Where is the right place to ask some questions related to build
environment?

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/1495365

Title:
  Compilation fails when compiling with VC++ 2010 Express

Status in Hugin:
  Fix Committed

Bug description:
  Compilation of the latest default branch (0ef305) fails when compiling
  with Visual C++ 2010 Express. One error is related to log1p() which
  isn't available under VC++ 2010 and the second is caused by "ambiguous
  call to overloaded function" sqrt(). Appropriate patch is in the
  attachment.

  Best regards,
  Jan

To manage notifications about this bug go to:
https://bugs.launchpad.net/hugin/+bug/1495365/+subscriptions