hugin-devs team mailing list archive
-
hugin-devs team
-
Mailing list archive
-
Message #07508
[Bug 1892420] Re: levmar uses BLAS when built with LAPACK, but Hugin does not link against BLAS
What is the error the build system report without the patch?
Also before applying the patch I would be interested in a comparison between self-contained levmar and levmar+LAPACK.
The photometric optimizer is the only part of Hugin which is using the embedded levmar lib. I don't know if using LAPACK (+BLAS) brings a speed or stability improvement. If there is no improvement of using LAPACK then maybe the LAPACK detection should be removed. When there is an improvement with LAPACK I would be interested how large this improvement is.
** Changed in: hugin
Status: New => Incomplete
--
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/1892420
Title:
levmar uses BLAS when built with LAPACK, but Hugin does not link
against BLAS
Status in Hugin:
Incomplete
Bug description:
```
hugin-2019.2.0/src/foreign/levmar/misc_core.c:45:#define GEMM LM_MK_BLAS_NAME(gemm)
```
This function is a BLAS function:
https://en.wikipedia.org/wiki/Basic_Linear_Algebra_Subprograms#Level_3
Thus, since levmar is built as a static library, Hugin itself should
call `find_package(BLAS)` and `huginbase` should link against
`BLAS_LIBRARIES`.
Attached patch fixes this (in an admittedly slightly crude way) for
me.
To manage notifications about this bug go to:
https://bugs.launchpad.net/hugin/+bug/1892420/+subscriptions
References