hugin-devs team mailing list archive

[Dennis Schridde <1892420@xxxxxxxxxxxxxxxxxx>]

> Also before applying the patch I would be interested in a comparison
between self-contained levmar and levmar+LAPACK.  [...]  If there is no
improvement of using LAPACK then maybe the LAPACK detection should be
removed.

If the benefits of this build-system feature of Hugin are unknown, I
agree it is a good idea to remove it.  Maybe someone will complain about
the removal and provide you with insights on why the option was
originally introduced.

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/1892420

Title:
  levmar uses BLAS when built with LAPACK, but Hugin does not link
  against BLAS

Status in Hugin:
  Incomplete
Status in hugin package in Gentoo Linux:
  Unknown

Bug description:
  ```
  hugin-2019.2.0/src/foreign/levmar/misc_core.c:45:#define GEMM LM_MK_BLAS_NAME(gemm)
  ```

  This function is a BLAS function:
  https://en.wikipedia.org/wiki/Basic_Linear_Algebra_Subprograms#Level_3

  Thus, since levmar is built as a static library, Hugin itself should
  call `find_package(BLAS)` and `huginbase` should link against
  `BLAS_LIBRARIES`.

  Attached patch fixes this (in an admittedly slightly crude way) for
  me.

To manage notifications about this bug go to:
https://bugs.launchpad.net/hugin/+bug/1892420/+subscriptions