← Back to team overview

hugin-devs team mailing list archive

[Bug 2016362] Re: Feature request: Add "Fit crop around images" button

 

*** This bug is a duplicate of bug 679939 ***
    https://bugs.launchpad.net/bugs/679939

> This was done for speed (see below). As I understand it, for non-masked/non-cropped images _some_ point on the source image's edge will be at its largest/smallest projected X/Y position in the final panorama; is this not the case?
Only for this special case. But not in the general case with fisheye lenses or cropping or masking.

>Aren't their edges always outside their interiors once projected?
No. The projection formula is only well-defined in the crop area. Outside of the crop it can remap points *far* away from the cropped edge. It can even be the case that the remapping operation is not (mathematically) defined (transformImgCoord returning false). So the calculation of the crop is wrong.

This is not addressed in the new patch.

I committed some changes to the repository which should implement an
outside crop.

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/2016362

Title:
  Feature request: Add "Fit crop around images" button

Status in Hugin:
  New

Bug description:
  It would be useful to have a button that sets the crop so that all of
  the pixels in the source images are in the final image (i.e. set the
  bounding box to surround all of the source images).

  This is similar (kind of opposite) in behavior to the "Stitcher→Fit
  Crop to Images" button that sets the crop so that there are no non-
  image pixels in final image.

  This is useful for when you want to be able to see all of the source
  images in the final image and don't care if it looks pretty.  The
  specific use-case that I have is documenting locations for
  cartography.  I want to be able to see all of a location and currently
  I have to manually set the crop for each panorama.

To manage notifications about this bug go to:
https://bugs.launchpad.net/hugin/+bug/2016362/+subscriptions



References