← Back to team overview

hugin-devs team mailing list archive

Re: [Bug 2028087] Re: Creating Mask crash fix

 

On 7/25/23 1:42 PM, tmodes wrote:
> Adding twice a comment with your initials and a date is not helpful. This can be tracked with mercurial.
> More helpful would be a comment with a description why the separate code block is necessary.
> 
> And why does it only happens with exclude region? Should be the same
> happen also with include region?
> 
> ** Changed in: hugin
>         Status: New => Incomplete
> 

Sorry about the comment... it was for my internal use and I forget to 
remove.

As for the separate code block, from stepping through with the debugger, 
there appears to be a race condition that appears to resolved by 
serializing in this fashion. If I recall correctly, I was getting a 
fault in the m_overlay.Reset() before the overlaydc.Clear() completed.

-phil
-- 
"Pretending that the all-but-inevitable is inconceivable doesn't
make it impossible."

Phillip W. Wong, PE (phil@xxxxxxxxxxxx)

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/2028087

Title:
  Creating Mask crash fix

Status in Hugin:
  Incomplete

Bug description:
  (using a my build of hugin-2022.0.0 on MacOS v10.12.6) When creating a
  mask for exclude region, hugin would sometimes crash. This attach
  patch fixes this issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/hugin/+bug/2028087/+subscriptions



References