hugin-devs team mailing list archive

[tmodes <2081969@xxxxxxxxxxxxxxxxxx>]

First, please use separate tickets for different issues. Merging
different issue in one ticket makes tracking and answering difficult.

First issue: the roi.
This code is in place since many years without problems. 
Before I do a change to such a prominent place I want to see a reproduce case. (ideally with *small* dummy images) to check for myself.
And please state which enblend version used with configuration (enblend --version --verbose). Don't use a modified version.

Second issue: the wx() macro.
Hugin needs wxWidgets >=3.0. 
Version 3.3 is an *unreleased* development version.

The documentation at https://docs.wxwidgets.org/latest/overview_changes_since28.html
states
<snip> macros wxT() and _T() are not needed at all any longer. … On the other hand, there is no particular harm in leaving them either as the code will still compile and work correctly –<snip>
Yes, they are deprecated. But either remove all occurrences or keep them.
But you patch is removing some macros and still use the same macro at the same time. So at least the explanation with deprecation is not valid.
So the cause for the compilation errors is a different one.

** Changed in: hugin
       Status: New => Incomplete

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/2081969

Title:
  hugin misaligns remapped images resulting in bad stitch

Status in Hugin:
  Incomplete

Bug description:
  remapped images are exported in the reference frame of the canvas
  instead of the ROI (the crop zone) resulting in bad stitches. the
  attached patch fixes this (wxT() has been deprecated in wxwidgets 3.3
  and is not needed anymore. i removed it only in places where i got
  compile errors but if you don't use the latest wxwidgets those changes
  can be ignored). this coupled with the patches for enblend/enfuse
  (https://bugs.launchpad.net/enblend/+bug/2081896) should result in
  good stitches again.

To manage notifications about this bug go to:
https://bugs.launchpad.net/hugin/+bug/2081969/+subscriptions