← Back to team overview

hugin-devs team mailing list archive

[Bug 2129804] [NEW] functions not marked as override, overflow in bitfield

 

Public bug reported:

Functions that override virtual functions inherited from wx should be
marked 'override'.

1-bit bitfields of type int have values {-1, 0}, and as a result setting
it to 1 is an integer overflow. The type should be unsigned int.

** Affects: hugin
     Importance: Undecided
         Status: New

** Patch added: "override_and_overflow.patch"
   https://bugs.launchpad.net/bugs/2129804/+attachment/5920352/+files/override_and_overflow.patch

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/2129804

Title:
  functions not marked as override, overflow in bitfield

Status in Hugin:
  New

Bug description:
  Functions that override virtual functions inherited from wx should be
  marked 'override'.

  1-bit bitfields of type int have values {-1, 0}, and as a result
  setting it to 1 is an integer overflow. The type should be unsigned
  int.

To manage notifications about this bug go to:
https://bugs.launchpad.net/hugin/+bug/2129804/+subscriptions



Follow ups