instant team mailing list archive

["Johannes Ring" <johannr@xxxxxxxxx>]

On Tue, September 2, 2008 14:32, Martin Sandve Alnæs wrote:
> 2008/9/2 Johannes Ring <johannr@xxxxxxxxx>:
>> On Tue, September 2, 2008 07:46, kent-and@xxxxxxxxx wrote:
>>>> I hope you didn't spend much time on this...
>>>>
>>>> I told you I had already done quite a bit  of cleaning up but didn't
>>>> dare checking in yet, I only wanted you to check the tests...
>>>>
>>>> I've rewritten almost everything now, the code is much
>>>> easier to follow and manage now, but it's not quite working
>>>> yet so I'm keeping it in my own repository until tomorrow.
>>>>
>>>> --
>>>> Martin
>>>>
>>>
>>> :) I started but didn't get it to work and decided on small steps
>>> instead..
>>> I look forward to your rewrite !
>>
>> Martin: Now that you are rewriting the code, could you switch from using
>> commands.getstatus*() to subprocess since commands.getstatus*() isn't
>> working in Windows and it will be deprecated in Python 2.6 (see [1] and
>> [2])? If you don't have time, I can submit a patch later.
>>
>> Johannes
>>
>> [1]
>> http://ivory.idyll.org/blog/mar-07/replacing-commands-with-subprocess
>> [2] http://mail.python.org/pipermail/python-dev/2007-March/072278.html
>
> Ok. I'm almost done, in the process of finally making the tests work
> now, will fix afterwards.

I see that you have switched to subprocess in most places now, only
src/instant/config.py remains. It would be great if you could fix that
too.

Johannes

> I've changed some names, I'll try to summarize.
>
> --
> Martin
>