instant team mailing list archive

[Martin Sandve Alnæs <martinal@xxxxxxxxx>]

You're right, this was a bug. SFC uses source_directory, but it
passes its own signature so the checksum code isn't used.

s/No!/Thanks :)/

Martin



On Fri, Apr 17, 2009 at 5:09 PM, Ilmar Wilbers <ilmarw@xxxxxxxxx> wrote:
> I know that. But computing the checksum for these files is done by looking
> at their contents, not their names. If this is not done, Instant will fail,
> saying that it cannot find the file in the case the arguments
> 'source_directory' is used (as it is looking for the file in the cwd instead
> of the given directory).
>
> ilmar
>
> Martin Sandve Alnæs wrote:
>>
>> No!
>>
>> The checksum can't depend on the place the code was generated!
>>
>> Martin
>>
>>
>>
>> On Fri, Apr 17, 2009 at 4:49 PM, Instant <instant@xxxxxxxxxx> wrote:
>>
>>>
>>> One or more new changesets pushed to the primary instant repository.
>>> A short summary of the last three changesets is included below.
>>>
>>> changeset:   295:92ed546452358f7ebb49710eccae2faba91feca0
>>> tag:         tip
>>> user:        Ilmar Wilbers <ilmarw@xxxxxxxxx>
>>> date:        Fri Apr 17 16:49:15 2009 +0200
>>> files:       src/instant/build.py
>>> description:
>>> Prepend source_directory to sources, wrap_headers, and local_headers for
>>> checksum calculation.
>>>
>>>
>>> changeset:   294:ecf1c0a21ea4bfdca7aaf71619668caeb3989b89
>>> user:        Ilmar Wilbers <ilmarw@xxxxxxxxx>
>>> date:        Fri Apr 17 16:07:39 2009 +0200
>>> files:       src/instant/build.py
>>> description:
>>> Add source_directory to debug output.
>>>
>>>
>>> changeset:   293:65597053892db397c1098d812ea1e72c38cdb9e7
>>> user:        Ilmar Wilbers <ilmarw@xxxxxxxxx>
>>> date:        Thu Apr 16 14:15:20 2009 +0200
>>> files:       tests/run_omp_test.sh
>>> description:
>>> Reflect file name change in test script.
>>>
>>>
>>> ----------------------------------------------------------------------
>>> For more details, visit http://www.fenics.org/hg/instant
>>> _______________________________________________
>>> Instant-dev mailing list
>>> Instant-dev@xxxxxxxxxx
>>> http://fenics.org/mailman/listinfo/instant-dev
>>>
>>>
>>
>> _______________________________________________
>> Instant-dev mailing list
>> Instant-dev@xxxxxxxxxx
>> http://fenics.org/mailman/listinfo/instant-dev
>>
>