← Back to team overview

instant team mailing list archive

Re: [Branch ~instant-core/instant/main] Rev 316: Updated ChangeLog

 

On Thu, Jun 23, 2011 at 7:09 PM, Johan Hake <johan.hake@xxxxxxxxx> wrote:
> On Thursday June 23 2011 09:54:00 Johannes Ring wrote:
>> On Thu, Jun 23, 2011 at 6:19 PM, Johan Hake <johan.hake@xxxxxxxxx> wrote:
>> > On Thursday June 23 2011 05:06:53 Johannes Ring wrote:
>> >> On Wed, Jun 22, 2011 at 9:56 PM,  <noreply@xxxxxxxxxxxxx> wrote:
>> >> > ------------------------------------------------------------
>> >> > revno: 316
>> >> > committer: Johan Hake <hake.dev@xxxxxxxxx>
>> >> > branch nick: instant
>> >> > timestamp: Wed 2011-06-22 12:54:58 -0700
>> >> > message:
>> >> >  Updated ChangeLog
>> >> > modified:
>> >> >  ChangeLog
>> >> >
>> >> >
>> >> > --
>> >> > lp:instant
>> >> > https://code.launchpad.net/~instant-core/instant/main
>> >> >
>> >> > You are subscribed to branch lp:instant.
>> >> > To unsubscribe from this branch go to
>> >> > https://code.launchpad.net/~instant-core/instant/main/+edit-subscripti
>> >> > on
>> >> >
>> >> > === modified file 'ChangeLog'
>> >> > --- ChangeLog   2011-06-18 05:32:06 +0000
>> >> > +++ ChangeLog   2011-06-22 19:54:58 +0000
>> >> > @@ -1,5 +1,5 @@
>> >> >  - Error log is now copied to ./instant/error/module_name/config.log
>> >> > -   for easier retrieval
>> >> > +   for easier retrieval and ./instant/error/config.log
>> >>
>> >> I guess you mean ~/.instant/error/compile.log?
>> >
>> > Yes! Fixed!
>>
>> Are you sure you didn't forgot the tilde ('~')? It's a ".instant"
>> folder in $HOME, not a "instant" folder in the current directory
>> ('./'), right?
>
> Yes! Fixed!

Almost! :-)

Here is a patch for the ChangeLog:

- - Error log is now copied to ~./instant/error/module_name/compile.log
-   and ./instant/error/compile.log for easier retrieval
+ - Error log is now copied to ~/.instant/error/module_name/compile.log
+   and ~/.instant/error/compile.log for easier retrieval

> You can also use:
>
>  instant.get_error_dir()
>
> In the test script. This function looks for INSTANT_ERROR_DIR and creates it
> if the directory does not exist.

Yes, good idea!

>> Another thing: How about cleaning up the "error" folder when running
>> instant-clean?
>
> It did, but it did not clean everything. I think it does now.

I get this when I run instant-clean now:

$ instant-clean
Created temp directory '/tmp/tmp2mm3OQ2011-6-23-19-21_instant'.
Removing 0 modules from Instant cache...
Removing 23 error logs from Instant cache...
Traceback (most recent call last):
  File "/home/johannr/fenics-dev/bin/instant-clean", line 57, in <module>
    os.remove(os.path.join(error_dir, error_log))
OSError: [Errno 21] Is a directory:
'/home/johannr/.instant/error/dolfin_compile_code_8141410e773e4310c4c20e4e1f1f22d4'

Johannes


Follow ups

References