← Back to team overview

kabikaboo team mailing list archive

[Bug 489629] Re: v1.6 - Kabikaboo should use gtk.FileChooserDialog instead of gtk.FileSelection

 

** Summary changed:

- Kabikaboo should use gtk.FileChooserDialog instead of gtk.FileSelection
+ v1.6 - Kabikaboo should use gtk.FileChooserDialog instead of gtk.FileSelection

-- 
v1.6 - Kabikaboo should use gtk.FileChooserDialog instead of gtk.FileSelection
https://bugs.launchpad.net/bugs/489629
You received this bug notification because you are a member of Kabikaboo
Team, which is subscribed to Kabikaboo.

Status in Kabikaboo: Fix Released
Status in Kabikaboo trunk series: Fix Released

Bug description:
gtk.FileSelection is deprecated and frankly looks rather out-of-date. I am including a patch for kabikaboo.py to use the prettier gtk.FileChooserDialog instead.

I got rather confused by lines 1137-1150 in your original source. It seems like you have two if/else clauses doing almost the same thing. Also 1165-1180. So that will probably need some cleanup.

I also got filters working for opening files, but for saving files, the filters appear to not be selected by default when we use set_filename, at least that's my guess.

I believe os.path.expanduser('~') is better than os.getenv('USERPROFILE') or os.getenv('HOME') .