← Back to team overview

kernel-packages team mailing list archive

Re: [Bug 1205741] Re: The route metrics added "ip route" are not being inherited by route cache entries

 

Joe,

These three seem to be relevant.

https://git.kernel.org/cgit/linux/kernel/git/stable/linux-
stable.git/commit/?h=linux-3.5.y&id=5faa5df1fa2024bd750089ff21dcc4191798263d

https://git.kernel.org/cgit/linux/kernel/git/stable/linux-
stable.git/commit/?h=linux-3.5.y&id=e304dfdb030bab29888151021843bd9e1743a535

https://git.kernel.org/cgit/linux/kernel/git/stable/linux-
stable.git/commit/?h=linux-3.5.y&id=55432d2b543a4b6dfae54f5c432a566877a85d90

In particular, the first one adds the mechanism to invalidate the
inetpeer tree when the route cache is invalidated because of a fib
metric change.

The second is a grand netdev merge.

The third seems to be an essential bug fix that prevents reference to
freed inetpeer entries.


tim


On Thu, 2013-08-08 at 17:38 +0000, Joseph Salisbury wrote:
> Do you happen to know the upstream SHA1 that fixes this bug in 3.5?
> 
> ** Changed in: linux (Ubuntu)
>    Importance: Undecided => Medium
> 
> ** Tags added: kernel-da-key
>

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1205741

Title:
  The route metrics added "ip route" are not being inherited by route
  cache entries

Status in “linux” package in Ubuntu:
  Confirmed

Bug description:
  There is a bug in the the management of inet peers which prevents route metrics like initcwnd from being inherited by route
  cache entries.  An example:

  $ ip route show
  default via 172.16.231.2 dev eth0  metric 100 
  172.16.231.0/24 dev eth0  proto kernel  scope link  src 172.16.231.26

  $ ip route show cache
  local 172.16.231.26 from 172.16.231.1 dev lo  src 172.16.231.26 
      cache <local,src-direct>  iif eth0
  172.16.231.1 from 172.16.231.26 dev eth0 
      cache  ipid 0xa13f

  $ ip route change 172.16.231.0/24 dev eth0  proto kernel  scope link
  src 172.16.231.26 initcwnd lock 100

  $ ip route show
  default via 172.16.231.2 dev eth0  metric 100 
  172.16.231.0/24 dev eth0  proto kernel  scope link  src 172.16.231.26  initcwnd 
  lock 100

  $ ip route show cache
  172.16.231.1 from 172.16.231.26 dev eth0 
      cache  ipid 0xa13f rtt 4ms rttvar 4ms cwnd 40
  local 172.16.231.26 from 172.16.231.1 dev lo  src 172.16.231.26 
      cache <local,src-direct>  iif eth0

  Note that the initcwnd metric is not being inherited by the cache entry for 172.16.231.1.  The problem is that the
  inetpeer cache is not flushed when the "ip route change" occurs.  Without this the metrics in the inetpeer are used
  to build the metrics of the route cache entry even though they are stale.

  A fix for this bug is in the 3.5.0 kernel from quantal.  It is a simple fix and could be easily applied to the 3.2.0 line of kernels.
  --- 
  AlsaVersion: Advanced Linux Sound Architecture Driver Version 1.0.24.
  AplayDevices: Error: [Errno 2] No such file or directory
  ApportVersion: 2.0.1-0ubuntu17.3
  Architecture: amd64
  ArecordDevices: Error: [Errno 2] No such file or directory
  AudioDevicesInUse: Error: command ['fuser', '-v', '/dev/snd/by-path', '/dev/snd/controlC0', '/dev/snd/pcmC0D0c', '/dev/snd/pcmC0D0p', '/dev/snd/pcmC0D1p', '/dev/snd/midiC0D0', '/dev/snd/seq', '/dev/snd/timer'] failed with exit code 1:
  CRDA: Error: [Errno 2] No such file or directory
  Card0.Amixer.info: Error: [Errno 2] No such file or directory
  Card0.Amixer.values: Error: [Errno 2] No such file or directory
  DistroRelease: Ubuntu 12.04
  HibernationDevice: RESUME=UUID=7b08c24a-933d-44c9-a398-a8cdfc722538
  InstallationMedia: Ubuntu-Server 12.04 LTS "Precise Pangolin" - Release amd64 (20120424.1)
  IwConfig: Error: [Errno 2] No such file or directory
  Lsusb:
   Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
   Bus 002 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
   Bus 002 Device 002: ID 0e0f:0003 VMware, Inc. Virtual Mouse
   Bus 002 Device 003: ID 0e0f:0002 VMware, Inc. Virtual USB Hub
  MachineType: VMware, Inc. VMware Virtual Platform
  MarkForUpload: True
  Package: linux (not installed)
  ProcEnviron:
   LANGUAGE=en_US:en
   TERM=vt102
   PATH=(custom, no user)
   LANG=en_US.UTF-8
   SHELL=/bin/ksh
  ProcFB:
   
  ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-3.2.0-49-generic root=UUID=a386ea91-d67b-492f-983e-8e19bdcef30e ro find_preseed=/preseed.cfg noprompt rootdelay=30 console=ttyS1,115200n8 kgdboc=kbd,ttyS1,115200n8
  ProcVersionSignature: Ubuntu 3.2.0-49.75-generic 3.2.46
  RelatedPackageVersions:
   linux-restricted-modules-3.2.0-49-generic N/A
   linux-backports-modules-3.2.0-49-generic  N/A
   linux-firmware                            1.79.4
  RfKill: Error: [Errno 2] No such file or directory
  Tags:  precise
  Uname: Linux 3.2.0-49-generic x86_64
  UpgradeStatus: No upgrade log present (probably fresh install)
  UserGroups: adm cdrom dip lpadmin plugdev sambashare sudo
  dmi.bios.date: 07/02/2012
  dmi.bios.vendor: Phoenix Technologies LTD
  dmi.bios.version: 6.00
  dmi.board.name: 440BX Desktop Reference Platform
  dmi.board.vendor: Intel Corporation
  dmi.board.version: None
  dmi.chassis.asset.tag: No Asset Tag
  dmi.chassis.type: 1
  dmi.chassis.vendor: No Enclosure
  dmi.chassis.version: N/A
  dmi.modalias: dmi:bvnPhoenixTechnologiesLTD:bvr6.00:bd07/02/2012:svnVMware,Inc.:pnVMwareVirtualPlatform:pvrNone:rvnIntelCorporation:rn440BXDesktopReferencePlatform:rvrNone:cvnNoEnclosure:ct1:cvrN/A:
  dmi.product.name: VMware Virtual Platform
  dmi.product.version: None
  dmi.sys.vendor: VMware, Inc.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1205741/+subscriptions


References