kernel-packages team mailing list archive

[Mathew Hodson <mathew.hodson@xxxxxxxxx>]

** Bug watch removed: Linux Kernel Bug Tracker #14912
   http://bugzilla.kernel.org/show_bug.cgi?id=14912

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/485556

Title:
  inotify oops with wd == 4096

Status in The Linux Kernel:
  Expired
Status in linux package in Ubuntu:
  Fix Released
Status in linux source package in Lucid:
  Fix Released
Status in linux source package in Dapper:
  Won't Fix
Status in linux source package in Hardy:
  Fix Released
Status in linux source package in Intrepid:
  Won't Fix
Status in linux source package in Jaunty:
  Fix Released
Status in linux source package in Karmic:
  Fix Released

Bug description:
  inotify_rm_watch() fails when you call it with watch descriptor 4096,
  even if this watch descriptor is valid.

  it only ever happens with 4096.  All other numbers work OK.

  this is really bad because the watch remains in effect and when the
  process exits, you get this from the kernel:

  [ 1097.904754] ------------[ cut here ]------------
  [ 1097.904775] WARNING: at /build/buildd/linux-2.6.31/fs/notify/inotify/inotify_fsnotify.c:129 idr_callback+0x49/0x70()
  [ 1097.904782] Hardware name: 7448CTO
  [ 1097.904787] inotify closing but id=0 for entry=ffff8800658af690 in group=ffff88007195b400 still in idr.  Probably leaking memory
  [ 1097.904794] Modules linked in: binfmt_misc ppdev bridge stp bnep kvm_intel kvm nfsd lockd nfs_acl auth_rpcgss sunrpc snd_hda_codec_conexant snd_hda_intel snd_hda_codec snd_hwdep snd_pcm_oss snd_mixer_oss snd_pcm snd_seq_dummy snd_seq_oss arc4 ecb snd_seq_midi snd_rawmidi snd_seq_midi_event iwlagn uvcvideo snd_seq iwlcore iptable_filter videodev snd_timer ip_tables snd_seq_device mac80211 v4l1_compat x_tables heci(C) v4l2_compat_ioctl32 snd psmouse thinkpad_acpi soundcore btusb led_class serio_raw snd_page_alloc cfg80211 lp nvram parport xfs exportfs fbcon tileblit font bitblit softcursor i915 drm i2c_algo_bit e1000e video output intel_agp
  [ 1097.904917] Pid: 2949, comm: fail Tainted: G        WC 2.6.31-16-generic #51~pre2-Ubuntu
  [ 1097.904922] Call Trace:
  [ 1097.904936]  [<ffffffff8105e7d8>] warn_slowpath_common+0x78/0xb0
  [ 1097.904945]  [<ffffffff8105e86c>] warn_slowpath_fmt+0x3c/0x40
  [ 1097.904952]  [<ffffffff81153c99>] idr_callback+0x49/0x70
  [ 1097.904962]  [<ffffffff812733d9>] idr_for_each+0x89/0xe0
  [ 1097.904970]  [<ffffffff81153c50>] ? idr_callback+0x0/0x70
  [ 1097.904979]  [<ffffffff81151814>] ? fsnotify_put_event+0x44/0x60
  [ 1097.904987]  [<ffffffff81153c32>] inotify_free_group_priv+0x22/0x40
  [ 1097.904996]  [<ffffffff81151973>] fsnotify_final_destroy_group+0x23/0x40
  [ 1097.905004]  [<ffffffff81151a78>] fsnotify_put_group+0x98/0xb0
  [ 1097.905012]  [<ffffffff81153ebf>] inotify_release+0x2f/0x50
  [ 1097.905020]  [<ffffffff81120cd0>] __fput+0xf0/0x210
  [ 1097.905027]  [<ffffffff81120e0d>] fput+0x1d/0x30
  [ 1097.905037]  [<ffffffff8111cec8>] filp_close+0x58/0x90
  [ 1097.905045]  [<ffffffff81060657>] put_files_struct+0x77/0xe0
  [ 1097.905052]  [<ffffffff8106070f>] exit_files+0x4f/0x60
  [ 1097.905060]  [<ffffffff81061a5b>] do_exit+0x14b/0x360
  [ 1097.905069]  [<ffffffff8106d594>] ? signal_wake_up+0x34/0x40
  [ 1097.905077]  [<ffffffff81061cb9>] do_group_exit+0x49/0xc0
  [ 1097.905085]  [<ffffffff8106f8db>] get_signal_to_deliver+0x1bb/0x3b0
  [ 1097.905093]  [<ffffffff8106d9ca>] ? __send_signal+0x16a/0x360
  [ 1097.905104]  [<ffffffff810119a0>] do_signal+0x70/0x1c0
  [ 1097.905115]  [<ffffffff81529b40>] ? _spin_lock_irq+0x10/0x20
  [ 1097.905122]  [<ffffffff8106c031>] ? sigprocmask+0x91/0x110
  [ 1097.905130]  [<ffffffff8106c4c2>] ? sys_rt_sigprocmask+0x82/0x110
  [ 1097.905138]  [<ffffffff81011b3f>] do_notify_resume+0x4f/0x60
  [ 1097.905146]  [<ffffffff8106c4c2>] ? sys_rt_sigprocmask+0x82/0x110
  [ 1097.905154]  [<ffffffff810120fb>] sysret_signal+0x7e/0xcf
  [ 1097.905161] ---[ end trace e98b6c8990922934 ]---
  [ 1097.905167] entry->group=(null) inode=(null) wd=4096
  ----

  the kernel telling me "Probably leaking memory" is particularly scary.

  
  i get this on the latest (stable) karmic kernel but i also get the same bug on the prerelease kernel from smb's PPA:
  Linux marzipan 2.6.31-16-generic #51~pre2-Ubuntu SMP Thu Nov 12 14:47:25 UTC 2009 x86_64 GNU/Linux

  
  i'll attach a test program that makes it happen pretty quickly.

To manage notifications about this bug go to:
https://bugs.launchpad.net/linux/+bug/485556/+subscriptions