← Back to team overview

kernel-packages team mailing list archive

[Bug 1427175] Re: dkms postinst should handle missing headers

 

So, while the postinst hook script still has code which never gets executed, this is not really harmful as the dkms call itself prints the same and actually does not return an error on a failure to build. Running the hook more often than required also does not seem to be harmful. It actually helps to have any nvidia driver after upgrades.
So I am closing this one as won't fix. Mario, if you feel to re-open it or pick parts of this if you like.

** Changed in: dkms (Ubuntu)
       Status: Confirmed => Won't Fix

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to dkms in Ubuntu.
https://bugs.launchpad.net/bugs/1427175

Title:
  dkms postinst should handle missing headers

Status in dkms package in Ubuntu:
  Won't Fix

Bug description:
  In the kernel post-install script of DKMS we have the following:

  if [ -x /usr/lib/dkms/dkms_autoinstaller ]; then
      exec /usr/lib/dkms/dkms_autoinstaller start $inst_kern > /dev/null
  fi

  if ! _check_kernel_dir $inst_kern ; then
      echo "dkms: WARNING: $kernel headers are missing, which may explain the above failures." >&2
      echo "      please install the $header_pkg package to fix this." >&2
  fi

  Supposedly the intention is to produce a warning if the kernel-headers
  are missing (might also cause the overall exit code to be 0). But
  execution of this script stops and is replaced by the
  dkms_autoinstaller when using exec. So it probably should be:

  if [ -x /usr/lib/dkms/dkms_autoinstaller ]; then
    if ! /usr/lib/dkms/dkms_autoinstaller start $inst_kern > /dev/null; then
      if !_check_kernel_dir $inst_kern ; then
     ...

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/dkms/+bug/1427175/+subscriptions


References