kernel-packages team mailing list archive

[Colin Ian King <1434183@xxxxxxxxxxxxxxxxxx>]

Fix tested on trusty,  $ uname -a
Linux ubuntu 3.16.0-34-generic #45~14.04.1-Ubuntu SMP Tue Mar 24 11:14:29 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

Works fine with the -proposed kernel

** Tags removed: verification-needed-trusty
** Tags added: verification-done-trusty

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1434183

Title:
  btrfs: compress-force needs clearing when remounting with compress
  option

Status in linux package in Ubuntu:
  Fix Released
Status in linux source package in Trusty:
  Fix Committed
Status in linux source package in Utopic:
  Fix Committed

Bug description:
  SRU Justification:  (Trusty, Utopic)

  [Impact]
  Remounting from compress-force to compress could not clear compress-force option. The problem is there is no way for users to clear compress-force option separately. 

  [Fix]
  upstream commit 4027e0f4c4b2df28d564560a3c65c179bebae4c8
  "Btrfs: clear compress-force when remounting with compress option"

  this is a simple one-liner, risk is low to zero.

  [Testcase]
  See attached hacked up bash script.btrfs: Without the fix I can reproduce the oops every time. With the fix, it works perfectly.

  echo "MNT=$MNT"
  echo "TMP=$TMP"

  TMPIMG=$TMP/test.img
  DEV=/dev/loop0

  truncate --size 1500m $TMPIMG
  losetup $DEV $TMPIMG
  mkfs.btrfs -f $DEV
  mount $DEV $MNT -o compress-force=lzo
  mount $DEV $MNT -o remount,compress=zlib
  n=$(cat /proc/mounts | grep $DEV | grep "compress-force=zlib" | wc -l)
  umount $DEV
  losetup -d $DEV
  rm $TMPIMG

  if [ $n -eq 0 ]; then
          echo "compress-force=zlib cleared in remount"
          exit 0
  else
          echo "compress-force=zlib NOT cleared in remount"
          exit 1
  fi

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1434183/+subscriptions