kernel-packages team mailing list archive

[Adam Lee <adam.lee@xxxxxxxxxxxxx>]

On Thu, May 28, 2015 at 07:48:23AM -0500, Seth Forshee wrote:
> This doesn't make any sense to me. All of the detection done by this
> patch happens when the device is probed, and once INPUT_PROP_BUTTONPAD
> is set it shouldn't get cleared later due to heavy load. The device is
> defined in the ACPI tables, so it's not going to be vanishing then
> reappearing to be reprobed.
>
> So I'm skeptical that this patch really fixes the problem. Not that I
> think it will do any harm, but I can't understand how it would possibly
> help.
>
> Seth

@Shih-Yuan, please double check your testing? if "HID: multitouch: add
support of clickpads" is not sufficient and your problem is fixed by
"HID: multitouch: Add support for button type usage".

I'm checking the code at the same time.

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1456881

Title:
  Some touchpads' right button doesn't work under I2C mode, need support
  of clickpads

Status in HWE Next Project:
  In Progress
Status in linux package in Ubuntu:
  In Progress
Status in linux source package in Trusty:
  Fix Committed
Status in linux source package in Utopic:
  Fix Committed

Bug description:
  We need to add this support, otherwise some touchpads' right button
  doesn't work under I2C mode.

  commit	015fdaa9f8edd89a456b3331088e1b77ebdad9d0 (patch)
  HID: multitouch: add support of clickpads
  Touchpads that have only one button are called clickpads and should
  be advertised as such by the kernel.

  Signed-off-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
  Tested-by: Jason Ekstrand <jason@xxxxxxxxxxxxxx>
  Signed-off-by: Jiri Kosina <jkosina@xxxxxxx>

To manage notifications about this bug go to:
https://bugs.launchpad.net/hwe-next/+bug/1456881/+subscriptions