← Back to team overview

kernel-packages team mailing list archive

[Bug 1490895] [PATCH 4/4] ALSA: hda - Wake the codec up on pin/ELD notify events


Whenever there is an event from the i915 driver, wake the codec
and recheck plug/unplug + ELD status.

This fixes the issue with lost unsol events in power save mode,
the codec and controller can now sleep in D3 and still know when
the HDMI monitor has been connected.

Right now, this might mean we get two callbacks from the same event,
one from the unsol event and one from the i915 driver, but this is
not harmful and can be optimised away in a later patch.

Signed-off-by: David Henningsson <david.henningsson@xxxxxxxxxxxxx>
 sound/pci/hda/patch_hdmi.c | 21 ++++++++++++++++++++-
 1 file changed, 20 insertions(+), 1 deletion(-)

diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index b422e40..8fe466b 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -40,6 +40,7 @@
 #include "hda_codec.h"
 #include "hda_local.h"
 #include "hda_jack.h"
+#include "hda_intel.h"
 static bool static_hdmi_pcm;
 module_param(static_hdmi_pcm, bool, 0644);
@@ -145,6 +146,9 @@ struct hdmi_spec {
 	struct hda_multi_out multiout;
 	struct hda_pcm_stream pcm_playback;
+	/* i915/powerwell (Haswell+/Valleyview+) specific */
+	struct i915_audio_component_audio_ops i915_audio_ops;
@@ -2201,6 +2205,9 @@ static void generic_hdmi_free(struct hda_codec *codec)
 	struct hdmi_spec *spec = codec->spec;
 	int pin_idx;
+	if (is_haswell_plus(codec) || is_valleyview_plus(codec))
+		snd_hdac_i915_register_notifier(NULL);
 	for (pin_idx = 0; pin_idx < spec->num_pins; pin_idx++) {
 		struct hdmi_spec_per_pin *per_pin = get_pin(spec, pin_idx);
@@ -2327,6 +2334,14 @@ static void haswell_set_power_state(struct hda_codec *codec, hda_nid_t fg,
 	snd_hda_codec_set_power_to_all(codec, fg, power_state);
+static void intel_pin_eld_notify(void *audio_ptr, int port)
+	struct hda_codec *codec = audio_ptr;
+	int pin_nid = port + 0x04;
+	check_presence_and_report(codec, pin_nid);
 static int patch_generic_hdmi(struct hda_codec *codec)
 	struct hdmi_spec *spec;
@@ -2344,8 +2359,12 @@ static int patch_generic_hdmi(struct hda_codec *codec)
-	if (is_haswell_plus(codec) || is_valleyview_plus(codec))
+	if (is_haswell_plus(codec) || is_valleyview_plus(codec)) {
 		codec->depop_delay = 0;
+		spec->i915_audio_ops.audio_ptr = codec;
+		spec->i915_audio_ops.pin_eld_notify = intel_pin_eld_notify;
+		snd_hdac_i915_register_notifier(&spec->i915_audio_ops);
+	}
 	if (hdmi_parse_codec(codec) < 0) {
 		codec->spec = NULL;

You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.

  Skylake/Broadwell/Haswell: No HDMI audio jack detection in D3

Status in linux package in Ubuntu:
  In Progress

Bug description:
  This is a long-standing bug for some Haswell, Broadwell and most
  Skylake machines.

  When the HDA audio controller is in D3, a hotplug event (i e, HDMI or
  DisplayPort being plugged in) fails to wake up the audio side so it
  never registers that something has happened.

  By having the i915 driver call directly into the hda driver, the HDA
  driver is always notified that an HDMI hotplug event has happened.

To manage notifications about this bug go to: